Skip to content

Remove remaining references to internal_stack #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krzysztofczyz-da merged 2 commits into from
Jan 21, 2026
Merged

Remove remaining references to internal_stack #3633

krzysztofczyz-da merged 2 commits into from
Jan 21, 2026
+37 −50

Conversation

@krzysztofczyz-da
Copy link
Contributor

@krzysztofczyz-da krzysztofczyz-da commented Jan 21, 2026 •
edited
Loading

This PR removes refs to internal_stack.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@krzysztofczyz-da krzysztofczyz-da force-pushed the kczyz/remove-refs-to-internal branch from 191ad57 to 5fc8d82 Compare January 21, 2026 11:18
@krzysztofczyz-da krzysztofczyz-da added the static Used to label PRs for which static tests suffice label Jan 21, 2026
@krzysztofczyz-da
Remove remaining references to internal_stack
31e2580 
This PR removes refs to internal_stack.

Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
@krzysztofczyz-da krzysztofczyz-da force-pushed the kczyz/remove-refs-to-internal branch from 5fc8d82 to 31e2580 Compare January 21, 2026 12:24
@krzysztofczyz-da krzysztofczyz-da marked this pull request as ready for review January 21, 2026 12:26
martinflorian-da
martinflorian-da approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@martinflorian-da martinflorian-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Consider always referencing the relevant issue in the future, for context. Even if it's not public... it will be visible to the reviewers :))

(https://github.com/DACH-NY/canton-network-internal/issues/2735)

@krzysztofczyz-da @martinflorian-da
Fix ordering
4768882 
Co-authored-by: Martin Florian <martin.florian@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
@krzysztofczyz-da krzysztofczyz-da merged commit b1eb83a into main Jan 21, 2026
44 checks passed
@krzysztofczyz-da krzysztofczyz-da deleted the kczyz/remove-refs-to-internal branch January 21, 2026 14:15
@isegall-da
Copy link
Contributor

isegall-da commented Jan 21, 2026

@krzysztofczyz-da @martinflorian-da this broke backups: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/48371/workflows/fcf2c93f-96a5-4057-ab51-499f50d23490/jobs/263338/parallel-runs/1

I'm reverting for now.

isegall-da added a commit that referenced this pull request Jan 21, 2026
@isegall-da
[static] Revert "Remove remaining references to internal_stack (#3633)"
6b22caf 
This reverts commit b1eb83a.

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
isegall-da added a commit that referenced this pull request Jan 21, 2026
@isegall-da
Revert "Remove remaining references to internal_stack (#3633)" (#3645)
b13608d 
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
martinflorian-da added a commit that referenced this pull request Jan 22, 2026
@martinflorian-da
Reapply "Remove remaining references to internal_stack (#3633)" (#3645)
9589e01 
This reverts commit b13608d.
@martinflorian-da martinflorian-da mentioned this pull request Jan 22, 2026
Merged
martinflorian-da added a commit that referenced this pull request Jan 22, 2026
@martinflorian-da
Reapply "Remove remaining references to internal_stack (#3633)" (#3645)
a9510c9 
This reverts commit b13608d.

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
martinflorian-da added a commit that referenced this pull request Jan 22, 2026
@martinflorian-da
Remove remaining references to internal_stack (fixed) (#3649)
400eb81 
- **Reapply "Remove remaining references to internal_stack (#3633)" (#3645)**
- **fix it**

TODO: Fire the original the reviewer of #3633

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinflorian-da martinflorian-da martinflorian-da approved these changes

Assignees

No one assigned

Labels

static Used to label PRs for which static tests suffice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krzysztofczyz-da @isegall-da @martinflorian-da