Skip to content

[ci] de-flake app rewards test #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isegall-da merged 2 commits into from
Jan 21, 2026
Merged

[ci] de-flake app rewards test #3643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
addd5b8
[ci] de-flake app rewards test
isegall-da Jan 21, 2026
a8c4d69
[ci] .
isegall-da Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import com.digitalasset.canton.logging.SuppressionRule
import org.slf4j.event.Level

import java.time.Duration
import scala.concurrent.duration.DurationInt
import scala.jdk.CollectionConverters.*

class WalletManualRoundsIntegrationTest
Expand Down Expand Up @@ -315,9 +314,8 @@ class WalletManualRoundsIntegrationTest

aliceWalletClient.tap(20.0)

eventually(40.seconds) {
aliceValidatorWalletClient.listAppRewardCoupons() should be(empty)
}
// We might have app reward coupons still from previous tests, we'll just ignore those in later stages of this test
val initialAppRewardCoupons = aliceValidatorWalletClient.listAppRewardCoupons()

clue("Check that no payment requests exist") {
aliceWalletClient.listAppPaymentRequests() shouldBe empty
Expand All @@ -344,7 +342,11 @@ class WalletManualRoundsIntegrationTest
"Request no longer exists and validator has one unfeatured app reward",
_ => {
aliceWalletClient.listAppPaymentRequests() should have length 0
inside(aliceValidatorWalletClient.listAppRewardCoupons()) { case Seq(c) =>
inside(
aliceValidatorWalletClient
.listAppRewardCoupons()
.filter(!initialAppRewardCoupons.contains(_))
) { case Seq(c) =>
// Award for the first (locking) leg goes to the sender's validator
// The wallet is not a featured app, so no featured app reward even if the validator party is featured!
c.payload.featured shouldBe false
Expand Down
Loading