Skip to content

[static] Revert "Remove remaining references to internal_stack (#3633)" #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isegall-da merged 1 commit into from
Jan 21, 2026
Merged

[static] Revert "Remove remaining references to internal_stack (#3633)" #3645

isegall-da merged 1 commit into from
Jan 21, 2026
+50 −37

Conversation

@isegall-da
Copy link
Contributor

@isegall-da isegall-da commented Jan 21, 2026

This reverts commit b1eb83a.

This broke the backups, see https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/48371/workflows/fcf2c93f-96a5-4057-ab51-499f50d23490/jobs/263338

@krzysztofczyz-da @martinflorian-da Let's make sure to run cluster_test on the fix once you have it.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@isegall-da
[static] Revert "Remove remaining references to internal_stack (#3633)"
6b22caf 
This reverts commit b1eb83a.

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da enabled auto-merge (squash) January 21, 2026 19:59
@isegall-da isegall-da merged commit b13608d into main Jan 21, 2026
45 checks passed
@isegall-da isegall-da deleted the isegall/revert-internal-stack branch January 21, 2026 20:07
martinflorian-da added a commit that referenced this pull request Jan 22, 2026
@martinflorian-da
Reapply "Remove remaining references to internal_stack (#3633)" (#3645)
9589e01 
This reverts commit b13608d.
@martinflorian-da martinflorian-da mentioned this pull request Jan 22, 2026
Merged
martinflorian-da added a commit that referenced this pull request Jan 22, 2026
@martinflorian-da
Reapply "Remove remaining references to internal_stack (#3633)" (#3645)
a9510c9 
This reverts commit b13608d.

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
martinflorian-da added a commit that referenced this pull request Jan 22, 2026
@martinflorian-da
Remove remaining references to internal_stack (fixed) (#3649)
400eb81 
- **Reapply "Remove remaining references to internal_stack (#3633)" (#3645)**
- **fix it**

TODO: Fire the original the reviewer of #3633

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephencompall-DA stephencompall-DA stephencompall-DA approved these changes

@martinflorian-da martinflorian-da Awaiting requested review from martinflorian-da

@krzysztofczyz-da krzysztofczyz-da Awaiting requested review from krzysztofczyz-da

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isegall-da @stephencompall-DA