add support for migrating cometbft pvcs to hyperdisk #3658
Merged
+126
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
nicu-da
force-pushed
the
nicuda/techdebt/add_support_cometbft_hd
branch
from
e98e128 to
d767131
Compare
nicu-da
commented
Jan 22, 2026
Comment on lines
-146
to
-201
| const svIdentifier = nodeConfigs.selfSvNodeName; | ||
| const svIdentifierWithMigration = `${svIdentifier}-m${migrationId}`; | ||
| let volumeDependecies: Resource[] = []; | ||
| if (svConfiguration?.cometbft?.snapshotName) { | ||
| const volumeSize = cometbftChartValues.db.volumeSize; | ||
| const diskSnapshot = gcp.compute.getSnapshot({ | ||
| name: svConfiguration.cometbft.snapshotName, | ||
| }); | ||
|
|
||
| if (!GCP_ZONE) { | ||
| throw new Error('Zone is required to create a disk'); | ||
| } | ||
| const restoredDisk = new gcp.compute.Disk( | ||
| `${svIdentifierWithMigration}-cometbft-restored-data`, | ||
| { | ||
| name: `${svIdentifierWithMigration}-cometbft-restored-disk`, | ||
| // eslint-disable-next-line promise/prefer-await-to-then | ||
| size: diskSnapshot.then(snapshot => snapshot.diskSizeGb), | ||
| // eslint-disable-next-line promise/prefer-await-to-then | ||
| snapshot: diskSnapshot.then(snapshot => snapshot.selfLink), | ||
| type: 'pd-ssd', | ||
| zone: GCP_ZONE, | ||
| }, | ||
| opts | ||
| ); | ||
|
|
||
| // create the underlying persistent volume that will be used by cometbft from the state of an existing PV | ||
| volumeDependecies = [ | ||
| new k8s.core.v1.PersistentVolume( | ||
| `${svIdentifier}-cometbft-data`, | ||
| { | ||
| metadata: { | ||
| name: `${svIdentifier}-cometbft-data-pv`, | ||
| }, | ||
| spec: { | ||
| capacity: { | ||
| storage: volumeSize, | ||
| }, | ||
| volumeMode: 'Filesystem', | ||
| accessModes: ['ReadWriteOnce'], | ||
| persistentVolumeReclaimPolicy: 'Delete', | ||
| storageClassName: cometbftChartValues.db.volumeStorageClass, | ||
| claimRef: { | ||
| name: `global-domain-${migrationId}-cometbft-cometbft-data`, | ||
| namespace: xns.ns.metadata.name, | ||
| }, | ||
| csi: { | ||
| driver: 'pd.csi.storage.gke.io', | ||
| volumeHandle: restoredDisk.id, | ||
| }, | ||
| }, | ||
| }, | ||
| opts | ||
| ), | ||
| ]; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is just dead code we use for the cluster migration
martinflorian-da
approved these changes
Jan 22, 2026
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: {{ include "prefix" (list .Values "cometbft-data") }} | ||
| name: {{ .Values.db.pvcName | default (include "prefix" (list .Values "cometbft-data")) }} |
Contributor
There was a problem hiding this comment.
Once again I bow before your bravery to change YAML without a test...
Contributor
There was a problem hiding this comment.
(looks fairly reasonable to me... but doesn't it always?
Contributor
Author
There was a problem hiding this comment.
tested manually but also added tests for everything now
[static] Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[static]
same as #3653 but not it's a deployment, but we set the keep helm values for pvcs so they are not auto deleted
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines