Fix cncluster backup_nodes ignoring supplied nodes #3671
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
martinflorian-da
approved these changes
Jan 23, 2026
Contributor
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
Looks like #3672 which looks right
Thank you!
Contributor
|
I'm pretty sure now that this is actually the root cause of the cimain backup issues. We're creating pvc snapshots in parallel for the same thing, which then fails with "An operation with the given Volume ID projects/da-cn-ci/zones/us-central1-a/disks/pvc-3efe79dd-935e-41c9-86a0-6d09879b4f04 already exists", and that's when things start getting messy. I'm going ahead and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/cn-test-failures/issues/7034
Looks like fallout from the "internal" flag changes.
Bash strikes again!
It's late, it's Friday and it's bash - so please make triple sure that I didn't mess something up.
Needs backport to release-line-0.5.7 where things are breaking