Skip to content

Fix cncluster backup_nodes ignoring supplied nodes #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isegall-da merged 1 commit into from
Jan 23, 2026
+4 −2
Merged

Fix cncluster backup_nodes ignoring supplied nodes #3672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions build-tools/cncluster
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,10 +1746,12 @@ function subcmd_backup_nodes() {
fi
migration_id=$1

if [ $# -eq 2 ]; then
# If only migration is set, backup everything, otherwise backup specified nodes
# Notably, prod networks which don't have sv-2 % sv-3
if [ $# -eq 1 ]; then
nodes="sv-1 sv-2 sv-3 sv-da-1 validator1 splitwell"
else
shift 2
shift 1
nodes="$*"
fi

Expand Down