Skip to content

Revert "Increase backup wait time and delete timeouts in nod… #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isegall-da merged 1 commit into from
Jan 23, 2026
+2 −6
Merged

Revert "Increase backup wait time and delete timeouts in nod… #3674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions cluster/scripts/node-backup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ source "${TOOLS_LIB}/libcli.source"
source "${SPLICE_ROOT}/cluster/scripts/utils.source"

RUN_ID=$(date +%s)
WAIT_FOR_BACKUP_RETRIES=450

##### PVC Backup & Restore

Expand Down Expand Up @@ -55,7 +54,7 @@ function wait_for_pvc_backup() {
_info "Backup of $description PVC ready!"
break
else
(( i++ )) && (( i > WAIT_FOR_BACKUP_RETRIES )) && {
(( i++ )) && (( i > 300 )) && {
# remove the finalizers to allow fully deleting them
kubectl patch -n "$namespace" volumesnapshot "$pvc_name" -p '{"metadata":{"finalizers": []}}' --type=merge
kubectl delete volumesnapshot -n "$namespace" "$backupName";
Expand Down Expand Up @@ -154,10 +153,7 @@ function wait_for_cloudsql_backup() {
_info "Backup of $description ready! Backup ID: $id "
break
else
(( i++ ))&& (( i > WAIT_FOR_BACKUP_RETRIES )) && {
# gcloud sql backups delete "$id" --instance "$db_id" --quiet;
_error "Timed out waiting for backup of $description db";
}
(( i++ ))&& (( i > 300 )) &&_error "Timed out waiting for backup of $description db"
sleep 5
_info "still waiting..."
fi
Expand Down