Skip to content

Comments

IGNORE: CI test for wip temporal ACS store#4061

Draft
dfordivam wants to merge 5 commits intomainfrom
dfordivam/cip-104-wip-temporal-acs-store-test
Draft

IGNORE: CI test for wip temporal ACS store#4061
dfordivam wants to merge 5 commits intomainfrom
dfordivam/cip-104-wip-temporal-acs-store-test

Conversation

@dfordivam
Copy link
Contributor

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Copy link
Contributor Author

@meiersi-da could you take a look at 011d95c and confirm this is the right direction for the implementation?

@meiersi-da
Copy link
Contributor

@meiersi-da could you take a look at 011d95c and confirm this is the right direction for the implementation?

Very nice. Yes, that matches what I had in mind. Nice touch with the configuration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants