[DRAFT] CIP-104: Daml: Reward assignment interface

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/AppUpgradeIntegrationTest.scala

@@ -265,6 +265,7 @@ class AppUpgradeIntegrationTest
             amuletConfig.featuredAppActivityMarkerAmount,
             amuletConfig.optDevelopmentFundManager,
             amuletConfig.externalPartyConfigStateTickDuration,
+            amuletConfig.rewardConfig,
           )
           val upgradeAction = new ARC_AmuletRules(
             new CRARC_SetConfig(

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigIntegrationTest.scala

@@ -233,6 +233,7 @@ class BootstrapPackageConfigIntegrationTest
         amuletConfig.featuredAppActivityMarkerAmount,
         amuletConfig.optDevelopmentFundManager,
         amuletConfig.externalPartyConfigStateTickDuration,
+        amuletConfig.rewardConfig,
       )
 
       val upgradeAction = new ARC_AmuletRules(
@@ -382,6 +383,7 @@ class BootstrapPackageConfigIntegrationTest
         amuletConfig.featuredAppActivityMarkerAmount,
         amuletConfig.optDevelopmentFundManager,
         amuletConfig.externalPartyConfigStateTickDuration,
+        amuletConfig.rewardConfig,
       )
 
       val upgradeAction = new ARC_AmuletRules(

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/DevelopmentFundFrontendTimeBasedIntegrationTest.scala

@@ -444,6 +444,7 @@ class DevelopmentFundFrontendTimeBasedIntegrationTest
       existingConfig.featuredAppActivityMarkerAmount,
       Optional.of(newDfm.toProtoPrimitive),
       existingConfig.externalPartyConfigStateTickDuration,
+      existingConfig.rewardConfig,
     )
 
     val action = new ARC_AmuletRules(

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SvReconcileSynchronizerConfigIntegrationTest.scala

@@ -143,6 +143,7 @@ class SvReconcileSynchronizerConfigIntegrationTest extends SvIntegrationTestBase
     amuletConfig.featuredAppActivityMarkerAmount,
     amuletConfig.optDevelopmentFundManager,
     amuletConfig.externalPartyConfigStateTickDuration,
+    amuletConfig.rewardConfig,
   )
 
 }

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SvStateManagementIntegrationTest.scala

@@ -495,6 +495,7 @@ class SvStateManagementIntegrationTest extends SvIntegrationTestBase with Trigge
       initialConfig.featuredAppActivityMarkerAmount,
       initialConfig.optDevelopmentFundManager,
       initialConfig.externalPartyConfigStateTickDuration,
+      initialConfig.rewardConfig,
     )
 
     val (_, voteRequestCid) = actAndCheck(

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/UnsupportedPackageVettingIntegrationTest.scala

@@ -166,6 +166,7 @@ class UnsupportedPackageVettingIntegrationTest
           currentConfig.featuredAppActivityMarkerAmount,
           currentConfig.optDevelopmentFundManager,
           currentConfig.externalPartyConfigStateTickDuration,
+          currentConfig.rewardConfig,
         )
         setAmuletConfig(Seq((None, newAmuletConfig, currentConfig)))
       }

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/util/AmuletConfigUtil.scala

@@ -63,6 +63,7 @@ trait AmuletConfigUtil extends TestCommon {
       existingAmuletConfig.featuredAppActivityMarkerAmount,
       existingAmuletConfig.optDevelopmentFundManager,
       existingAmuletConfig.externalPartyConfigStateTickDuration,
+      existingAmuletConfig.rewardConfig,
     )
   }
 

apps/common/frontend-test-handlers/src/mocks/helpers/amulet-config-helper.ts

@@ -227,6 +227,13 @@ export function getAmuletRulesConfig(
     featuredAppActivityMarkerAmount: null,
     optDevelopmentFundManager: null,
     externalPartyConfigStateTickDuration: null,
+    rewardConfig: {
+      mintingVersion: 'RewardVersion_FeaturedAppMarkers',
+      dryRunVersion: null,
+      batchSize: '100',
+      rewardCouponTimeToLive: { microseconds: '129600000000' },
+      appRewardCouponThreshold: '0.5',
+    },
   };
 }
 
@@ -394,6 +401,17 @@ export function getExpectedAmuletRulesConfigDiffsHTML(
   "validatorLifecycle": "0.1.2",
   "wallet": "0.1.8",
   "walletPayments": "0.1.8"
+}</pre></div></li><li data-key="rewardConfig"
+    class="jsondiffpatch-unchanged"><div
+      class="jsondiffpatch-property-name">rewardConfig</div><div
+      class="jsondiffpatch-value"><pre>{
+  "mintingVersion": "RewardVersion_FeaturedAppMarkers",
+  "dryRunVersion": null,
+  "batchSize": "100",
+  "rewardCouponTimeToLive": {
+    "microseconds": "129600000000"
+  },
+  "appRewardCouponThreshold": "0.5"
 }</pre></div></li><li data-key="tickDuration"
     class="jsondiffpatch-unchanged"><div
       class="jsondiffpatch-property-name">tickDuration</div><div

apps/common/frontend/src/__tests__/mocks/constants.ts

@@ -193,6 +193,7 @@ export const plannedVoteResult: DsoRules_CloseVoteRequestResult = {
                 featuredAppActivityMarkerAmount: null,
                 optDevelopmentFundManager: null,
                 externalPartyConfigStateTickDuration: null,
+                rewardConfig: null,
               },
             },
           },

apps/common/src/main/scala/org/lfdecentralizedtrust/splice/util/SpliceUtil.scala

@@ -395,6 +395,7 @@ object SpliceUtil {
       initialExternalPartyConfigStateTickDuration
         .map(t => new RelTime(TimeUnit.NANOSECONDS.toMicros(t.duration.toNanos)))
         .toJava,
+      Optional.empty(), // rewardConfig
     )
 
   def defaultAnsConfig(

apps/common/src/test/scala/org/lfdecentralizedtrust/splice/store/StoreTestBase.scala

@@ -282,6 +282,8 @@ abstract class StoreTestBase
       SpliceUtil.defaultTransferConfig(10, holdingFee),
       SpliceUtil.issuanceConfig(10.0, 10.0, 10.0),
       new RelTime(1_000_000),
+      Optional.empty(), // trafficPrice
+      Optional.empty(), // rewardConfig
     )
 
     contract(

apps/dar-resources-generator/src/main/scala/org/lfdecentralizedtrust/splice/darutils/DarResources.scala

@@ -82,6 +82,7 @@ object DarResources {
   lazy val amulet_0_1_15 = DarResource("splice-amulet-0.1.15.dar")
   lazy val amulet_0_1_16 = DarResource("splice-amulet-0.1.16.dar")
   lazy val amulet_0_1_17 = DarResource("splice-amulet-0.1.17.dar")
+  lazy val amulet_0_1_18 = DarResource("splice-amulet-0.1.18.dar")
   lazy val amulet_current = DarResource("splice-amulet-current.dar")
   lazy val amulet = PackageResource(
     amulet_current,
@@ -105,6 +106,7 @@ object DarResources {
       amulet_0_1_15,
       amulet_0_1_16,
       amulet_0_1_17,
+      amulet_0_1_18,
     ),
   )
 
@@ -133,6 +135,7 @@ object DarResources {
   lazy val dsoGovernance_0_1_22 = DarResource("splice-dso-governance-0.1.22.dar")
   lazy val dsoGovernance_0_1_23 = DarResource("splice-dso-governance-0.1.23.dar")
   lazy val dsoGovernance_0_1_24 = DarResource("splice-dso-governance-0.1.24.dar")
+  lazy val dsoGovernance_0_1_25 = DarResource("splice-dso-governance-0.1.25.dar")
   lazy val dsoGovernance_current = DarResource("splice-dso-governance-current.dar")
   lazy val dsoGovernance = PackageResource(
     dsoGovernance_current,
@@ -163,6 +166,7 @@ object DarResources {
       dsoGovernance_0_1_22,
       dsoGovernance_0_1_23,
       dsoGovernance_0_1_24,
+      dsoGovernance_0_1_25,
     ),
   )
 
@@ -185,6 +189,7 @@ object DarResources {
   lazy val amuletNameService_0_1_16 = DarResource("splice-amulet-name-service-0.1.16.dar")
   lazy val amuletNameService_0_1_17 = DarResource("splice-amulet-name-service-0.1.17.dar")
   lazy val amuletNameService_0_1_18 = DarResource("splice-amulet-name-service-0.1.18.dar")
+  lazy val amuletNameService_0_1_19 = DarResource("splice-amulet-name-service-0.1.19.dar")
   lazy val amuletNameService_current = DarResource("splice-amulet-name-service-current.dar")
   lazy val amuletNameService = PackageResource(
     amuletNameService_current,
@@ -209,6 +214,7 @@ object DarResources {
       amuletNameService_0_1_16,
       amuletNameService_0_1_17,
       amuletNameService_0_1_18,
+      amuletNameService_0_1_19,
     ),
   )
 
@@ -231,6 +237,7 @@ object DarResources {
   lazy val splitwell_0_1_16 = DarResource("splitwell-0.1.16.dar")
   lazy val splitwell_0_1_17 = DarResource("splitwell-0.1.17.dar")
   lazy val splitwell_0_1_18 = DarResource("splitwell-0.1.18.dar")
+  lazy val splitwell_0_1_19 = DarResource("splitwell-0.1.19.dar")
   lazy val splitwell_current = DarResource("splitwell-current.dar")
   lazy val splitwell = PackageResource(
     splitwell_current,
@@ -255,6 +262,7 @@ object DarResources {
       splitwell_0_1_16,
       splitwell_0_1_17,
       splitwell_0_1_18,
+      splitwell_0_1_19,
     ),
   )
 
@@ -277,6 +285,7 @@ object DarResources {
   lazy val wallet_0_1_16 = DarResource("splice-wallet-0.1.16.dar")
   lazy val wallet_0_1_17 = DarResource("splice-wallet-0.1.17.dar")
   lazy val wallet_0_1_18 = DarResource("splice-wallet-0.1.18.dar")
+  lazy val wallet_0_1_19 = DarResource("splice-wallet-0.1.19.dar")
   lazy val wallet_current = DarResource("splice-wallet-current.dar")
   lazy val wallet = PackageResource(
     wallet_current,
@@ -301,6 +310,7 @@ object DarResources {
       wallet_0_1_16,
       wallet_0_1_17,
       wallet_0_1_18,
+      wallet_0_1_19,
     ),
   )
 
@@ -322,6 +332,7 @@ object DarResources {
   lazy val walletPayments_0_1_15 = DarResource("splice-wallet-payments-0.1.15.dar")
   lazy val walletPayments_0_1_16 = DarResource("splice-wallet-payments-0.1.16.dar")
   lazy val walletPayments_0_1_17 = DarResource("splice-wallet-payments-0.1.17.dar")
+  lazy val walletPayments_0_1_18 = DarResource("splice-wallet-payments-0.1.18.dar")
   lazy val walletPayments_current = DarResource("splice-wallet-payments-current.dar")
   lazy val walletPayments = PackageResource(
     walletPayments_current,
@@ -345,6 +356,7 @@ object DarResources {
       walletPayments_0_1_15,
       walletPayments_0_1_16,
       walletPayments_0_1_17,
+      walletPayments_0_1_18,
     ),
   )