-
Notifications
You must be signed in to change notification settings - Fork 34
fix env var name change #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daisuke Kanda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates environment variable names in test scripts to align with a recent change from DEBUG_RELAYER_MISSING_TRIE_NODE_HEIGHT to DEBUG_RELAYER_PRUNE_AFTER_BLOCKS. The change affects only test configuration scripts without modifying the main codebase.
- Updated environment variable names in two test scripts to use the new
PRUNE_AFTER_BLOCKSnaming convention - Maintains the same configuration values (10 for both chain and prover configurations)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/tm2tm/scripts/test-tx | Updated DEBUG_RELAYER environment variable names from MISSING_TRIE_NODE_HEIGHT to PRUNE_AFTER_BLOCKS |
| tests/cases/tm2tm/scripts/test-service-fakelost | Updated DEBUG_RELAYER environment variable names from MISSING_TRIE_NODE_HEIGHT to PRUNE_AFTER_BLOCKS |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Daisuke Kanda <[email protected]>
| $RLY tx channel-upgrade init ibc01 ibc0 $origSrcOpts | ||
| $RLY tx channel-upgrade execute ibc01 --target-src-state FLUSHCOMPLETE --target-dst-state FLUSHING | ||
| $RLY tx channel-upgrade cancel ibc01 ibc1 # ibc1 returns to UNINIT. ibc0 is FLUSHCOMPLETE. | ||
| sleep 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dai1975 Why do we need to wait 10 seconds here?
Signed-off-by: Daisuke Kanda <[email protected]>
siburu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixed environment variables name in local test scripts.
Main code is not changed.