Skip to content

Conversation

@dai1975
Copy link
Contributor

@dai1975 dai1975 commented Sep 29, 2025

Fixed environment variables name in local test scripts.
Main code is not changed.

Signed-off-by: Daisuke Kanda <[email protected]>
@dai1975 dai1975 requested a review from Copilot September 29, 2025 02:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates environment variable names in test scripts to align with a recent change from DEBUG_RELAYER_MISSING_TRIE_NODE_HEIGHT to DEBUG_RELAYER_PRUNE_AFTER_BLOCKS. The change affects only test configuration scripts without modifying the main codebase.

  • Updated environment variable names in two test scripts to use the new PRUNE_AFTER_BLOCKS naming convention
  • Maintains the same configuration values (10 for both chain and prover configurations)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/cases/tm2tm/scripts/test-tx Updated DEBUG_RELAYER environment variable names from MISSING_TRIE_NODE_HEIGHT to PRUNE_AFTER_BLOCKS
tests/cases/tm2tm/scripts/test-service-fakelost Updated DEBUG_RELAYER environment variable names from MISSING_TRIE_NODE_HEIGHT to PRUNE_AFTER_BLOCKS

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Daisuke Kanda <[email protected]>
@dai1975 dai1975 requested a review from siburu September 29, 2025 03:50
@dai1975 dai1975 marked this pull request as ready for review September 29, 2025 03:51
@dai1975 dai1975 requested a review from a team as a code owner September 29, 2025 03:51
$RLY tx channel-upgrade init ibc01 ibc0 $origSrcOpts
$RLY tx channel-upgrade execute ibc01 --target-src-state FLUSHCOMPLETE --target-dst-state FLUSHING
$RLY tx channel-upgrade cancel ibc01 ibc1 # ibc1 returns to UNINIT. ibc0 is FLUSHCOMPLETE.
sleep 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dai1975 Why do we need to wait 10 seconds here?

Signed-off-by: Daisuke Kanda <[email protected]>
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siburu siburu merged commit 5f8885b into hyperledger-labs:main Oct 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants