Fix: Match Solidity behavior for memory array deletion (issue #1785) #1795
Check failed
There are 6 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 4de1994 | fix: match Solidity behavior for memory array dele... | Valid sign-off found |
| 🟢 | dde5337 | Merge branch 'main' into fix/1785-memory-array-del... | Skipped: sign-off not required in merge commit |
| 🟢 | b878bf4 | fix: match solc behavior for delete on memory arra... | Valid sign-off found |
| 🟢 | 59017ad | Merge branch 'main' into fix/1785-memory-array-del... | Skipped: sign-off not required in merge commit |
| 🟢 | c85debd | Merge branch 'main' into fix/1785-memory-array-del... | Skipped: sign-off not required in merge commit |
| 🔴 | dfa099c | Add warning for delete on non-storage references (... | Sign-off not found |
| 🔴 | 9f3c30e | Fix mutability analysis for delete statements - on... | Sign-off not found |
| 🔴 | 7e3f37d | Fix issue #1785: Improve delete statement handling... | Sign-off not found |
| 🔴 | d5336e0 | Fix issue #1785: Improve delete statement handling... | Sign-off not found |
| 🔴 | cd00373 | Fix issue #1785: Treat all delete operations as wr... | Sign-off not found |
| 🔴 | 24b56bd | Fix issue #1785: Implement delete operator behavio... | Sign-off not found |
| 🟢 | 92f0530 | AST remains accurate and No warnings for array ele... | Valid sign-off found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~12 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin fix/1785-memory-array-delete