Skip to content

remove totalDifficulty from blockResult #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Mar 17, 2025

Signed-off-by: Sally MacFarlane [email protected]## PR description

Fixed Issue(s)

totalDifficulty field was removed from block result in ethereum/execution-apis#570
This fixes several rpc-compat hive tests

fixes #8457

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10
Copy link
Contributor

fab-10 commented Mar 17, 2025

should this depend to PoW and Clique deprecation? Or depends on network config?

@macfarla macfarla added the hive relating to hive tests label Mar 25, 2025
@macfarla macfarla marked this pull request as draft March 25, 2025 04:57
Copy link

This pr is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Apr 25, 2025
@macfarla
Copy link
Contributor Author

macfarla commented May 7, 2025

should this depend to PoW and Clique deprecation? Or depends on network config?

think we can make this dependent on whether the block number is after the merge block number - waiting for #8506

@github-actions github-actions bot removed the Stale label May 7, 2025
Copy link

github-actions bot commented Jun 6, 2025

This pr is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hive relating to hive tests Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove totalDifficulty from blockResult
2 participants