-
Notifications
You must be signed in to change notification settings - Fork 929
remove totalDifficulty from blockResult #8430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
should this depend to PoW and Clique deprecation? Or depends on network config? |
This pr is stale because it has been open for 30 days with no activity. |
think we can make this dependent on whether the block number is after the merge block number - waiting for #8506 |
This pr is stale because it has been open for 30 days with no activity. |
Signed-off-by: Sally MacFarlane [email protected]## PR description
Fixed Issue(s)
totalDifficulty field was removed from block result in ethereum/execution-apis#570
This fixes several rpc-compat hive tests
fixes #8457
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests