-
Notifications
You must be signed in to change notification settings - Fork 930
Deprecate snap server experimental option and add stable option #8512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@garyschulte are we ready to remove the --X from snap server? |
besu/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Show resolved
Hide resolved
@@ -445,7 +457,7 @@ public SynchronizerConfiguration.Builder toDomainObject() { | |||
.trienodeCountPerRequest(snapsyncTrieNodeCountPerRequest) | |||
.localFlatAccountCountToHealPerRequest(snapsyncFlatAccountHealedCountPerRequest) | |||
.localFlatStorageCountToHealPerRequest(snapsyncFlatStorageHealedCountPerRequest) | |||
.isSnapServerEnabled(snapsyncServerEnabled) | |||
.isSnapServerEnabled(snapsyncServerEnabled || snapsyncServerEnabledExperimental) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the flow we typically use when we promote something out of experimental. Typically we just alias the -X and after a quarter or so just remove the flag. We can add a deprecation message without adding an additional flag .
That said, this isn't a horrible pattern. At a minimum there needs to be a CHANGELOG.md entry for this PR, and some text in the upcoming deprecation body that references it.
6db1bf9
to
f53300f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also update the log message in the startup summary to remove Experimental
from:
# Experimental Snap Sync server enabled
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
154f4ce
to
048df22
Compare
PR description
Deprecate --Xsnapsync-server-enabled and add --snapsync-server-enabled instead.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests