Skip to content

feat: allow exchanging p2p-host value via rlpx connection #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsamsiyu
Copy link

@tsamsiyu tsamsiyu commented Apr 3, 2025

PR description

This PR adds a new Besu config option p2p-host-share-via-rlpx, which is disabled by default. When enabled, it modifies the RLPx Hello message by including the node’s P2P address in the message body. As a result, the bonding node will use this advertised P2P address as the peer’s identity, instead of relying on the IP address from the TCP socket

Fixed Issue(s)

#8496

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@siladu siladu requested review from matthew1001 and pinges April 14, 2025 23:52
@macfarla
Copy link
Contributor

macfarla commented May 9, 2025

@matthew1001 any input on this one?

@vitali-zevako
Copy link

+1 for this feature, currently we need to restart nodes one by one in case of permissioning is enabled, so it finally resolves correct dns names of allowed nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants