Additional logging to plugin registration process #8544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: garyschulte <[email protected]>
macfarla
approved these changes
Apr 12, 2025
Gabriel-Trintinalia
requested changes
Apr 13, 2025
| if (config.isContinueOnPluginError()) { | ||
| LOG.error("Error matching or registering plugins. Plugins will not start.", e); | ||
| } else { | ||
| throw new RuntimeException("Error matching or registering plugins. Plugins will not start", e); |
Contributor
There was a problem hiding this comment.
Error matching or registering plugins. Besu will not start
| } | ||
|
|
||
| private List<BesuPlugin> detectPlugins(final PluginConfiguration config) { | ||
| LOG.debug("detecting plugin in configured besu.plugins.dir {}", config.getPluginsDir()); |
Contributor
There was a problem hiding this comment.
I wasn't able to get this to log with "DEBUG"
| final URL[] pluginJarURLs = | ||
| pluginFilesList | ||
| .filter(p -> p.getFileName().toString().endsWith(".jar")) | ||
| .peek(p -> LOG.debug("plugin jar url: {}", p)) |
Contributor
There was a problem hiding this comment.
Same as above, DEBUG did not work but maybe it is my configuration
Gabriel-Trintinalia
requested changes
Apr 14, 2025
| // if block import tracer provider is not specified by plugin, default to no tracing | ||
| .orElse((__) -> BlockAwareOperationTracer.NO_TRACING); | ||
| .orElse((__) -> { | ||
| LOG.info("Block Import uses NO_TRACING"); |
Contributor
There was a problem hiding this comment.
This will be logged every time that a block is processed. Maybe move the log outside of the lambda body or change it to trace
|
This pr is stale because it has been open for 30 days with no activity. |
|
This pr was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Simple PR, aids in plugin registration debugging and discovery via logging
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests