Skip to content

Disable transaction indexing during initial sync by default #8611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2025

Conversation

jframe
Copy link
Contributor

@jframe jframe commented May 9, 2025

Fixed Issue(s)

Follow up on #8181 to disable transaction indexing during sync by default.

This also promotes this to a non-experimental CLI option so that users that need to disable this are more easily able to do so.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@jframe jframe changed the title Disable transaction indexing by default Disable transaction indexing during sync by default May 9, 2025
Signed-off-by: Jason Frame <[email protected]>
…erOptions.java

Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
@jframe jframe marked this pull request as ready for review May 22, 2025 22:54
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made a suggestion about the changelog

@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label May 22, 2025
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
@jframe jframe changed the title Disable transaction indexing during sync by default Disable transaction indexing during initial sync by default May 23, 2025
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we want to enable in enterprise or performance-rpc profiles perhaps?

@jframe
Copy link
Contributor Author

jframe commented May 23, 2025

LGTM.

Do we want to enable in enterprise or performance-rpc profiles perhaps?

Not sure about performance-rpc. For enterprise the plan was to add it later if needed to the enterprise profile now we have the flag visible. The latest release isn't used by enterprise.

@jframe jframe enabled auto-merge (squash) May 23, 2025 00:26
@jframe jframe merged commit edd31e6 into hyperledger:main May 23, 2025
48 checks passed
@jframe jframe deleted the tx_indexing_default_off branch May 23, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-change-required Indicates an issue or PR that requires doc to be updated syncing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants