-
Notifications
You must be signed in to change notification settings - Fork 929
Disable transaction indexing during initial sync by default #8611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…l option Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
besu/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Outdated
Show resolved
Hide resolved
…erOptions.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Jason Frame <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, made a suggestion about the changelog
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Jason Frame <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do we want to enable in enterprise or performance-rpc profiles perhaps?
Not sure about performance-rpc. For enterprise the plan was to add it later if needed to the enterprise profile now we have the flag visible. The latest release isn't used by enterprise. |
Fixed Issue(s)
Follow up on #8181 to disable transaction indexing during sync by default.
This also promotes this to a non-experimental CLI option so that users that need to disable this are more easily able to do so.
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests