-
Notifications
You must be signed in to change notification settings - Fork 937
Solved Add db reset for Ephemery network on restart #8180 #8618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ojus Chugh <[email protected]>
Tagging @macfarla for the review. Thanks! |
here's what I did to test this
It feels a bit weird to have your database silently nuked. Even though it is by definition ephemeral. At very least a log message that indicates your db is starting again from scratch would be nice. Is this how other clients (geth, nethermind etc) deal with the ephemery network? Would be nice to be consistent |
This pr is stale because it has been open for 30 days with no activity. |
@ojuschugh1 I added some comments and questions above, please take a look |
PR description
Fixed Issue(s)
Solved issue -: #8180
Created a unit test case to check it is working properly or not as well-:
Try -:
gradlew.bat :besu:test --tests "org.hyperledger.besu.util.EphemeryDatabaseResetTest"
or
./gradlew :besu:test --tests 'org.hyperledger.besu.util.EphemeryDatabaseResetTest'
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests