Skip to content

Conversation

@pinges
Copy link
Contributor

@pinges pinges commented Nov 28, 2025

PR description

draft

@github-project-automation github-project-automation bot moved this to Backlog in RC 25.12.0 Dec 4, 2025
pinges and others added 27 commits December 15, 2025 10:25
* Update engine API

Signed-off-by: Miroslav Kovar <[email protected]>

* Add EngineGetPayloadV6Test

Signed-off-by: Miroslav Kovar <[email protected]>

* Revert changes to EngineForkchoiceUpdatedV3

Signed-off-by: Miroslav Kovar <[email protected]>

* Add EngineNewPayloadV5Test

Signed-off-by: Miroslav Kovar <[email protected]>

* Address code review comments

Signed-off-by: Miroslav Kovar <[email protected]>

* Fix failing test build

Signed-off-by: Miroslav Kovar <[email protected]>

* Fix failing test build

Signed-off-by: Miroslav Kovar <[email protected]>

---------

Signed-off-by: Miroslav Kovar <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* ADD: UInt256 implementation of evm's op MOD

Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Nikos Baxevanis <[email protected]>
Co-authored-by: Nikos Baxevanis <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Should fix support for running builds `./gradlew build` for besu when using a git-worktree setup. Previously there was a problem while parsing the besu version during the build since gradle was confused as to where to lookup for the commit hash.

Signed-off-by: [email protected] <[email protected]>
* add evm options to evmtool too
* Statically initiatise SignatureAlgorithm default instance for reference tests

---------

Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* add block timestamp to logs within transaction receipt and block receipts

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* Bump spec tests

Signed-off-by: Gabriel-Trintinalia <[email protected]>

* changelog

Signed-off-by: Gabriel-Trintinalia <[email protected]>

---------

Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* Add test summary reporting to block-test command

The block-test command now tracks and displays a summary of test
execution results, including total tests, passed/failed counts, and
a list of failed tests with their failure reasons. This improves
usability when running large test suites by providing a clear
overview of test outcomes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Bhargava Shastry <[email protected]>

* Refactor block-test summary output for better maintainability

Address code review feedback by:
- Extract separator string into SEPARATOR constant to reduce duplication
- Reuse failureReason variable in output statements instead of duplicating
  formatting logic

This improves code maintainability by consolidating the failure message
formatting in a single location.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Bhargava Shastry <[email protected]>

* Address review feedback: simplify TestResults implementation

- Remove unused testName parameter from recordPass() method
- Remove totalTests field and calculate it dynamically in printSummary()
  from passed + failed counts
- Simplify SEPARATOR constant by removing embedded newline and use
  explicit out.println() for consistent formatting
- Add hasTests() helper method to check if any tests were executed

This reduces redundant state tracking and improves code clarity.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Bhargava Shastry <[email protected]>

---------

Signed-off-by: Bhargava Shastry <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Usman Saleem <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* Implement era1 file export

Signed-off-by: Matilda Clerke <[email protected]>

* Clean up OutputStreamFactory to pass inspections

Signed-off-by: Matilda Clerke <[email protected]>

* fix javadoc

Signed-off-by: Matilda Clerke <[email protected]>

* fix javadoc

Signed-off-by: Matilda Clerke <[email protected]>

* fix more compile checks

Signed-off-by: Matilda Clerke <[email protected]>

* fix more compile checks

Signed-off-by: Matilda Clerke <[email protected]>

* fix more compile checks

Signed-off-by: Matilda Clerke <[email protected]>

* Output era1 files to supplied directory

Signed-off-by: Matilda Clerke <[email protected]>

* Implement accumulator and block index

Signed-off-by: Matilda Clerke <[email protected]>

* Fix compile errors

Signed-off-by: Matilda Clerke <[email protected]>

* Fix javadoc

Signed-off-by: Matilda Clerke <[email protected]>

* Couple of fixes, add logging

Signed-off-by: Matilda Clerke <[email protected]>

* Implement our own merkleizer, try many things

Signed-off-by: Matilda Clerke <[email protected]>

* Fix accumulator calculations

Signed-off-by: Matilda Clerke <[email protected]>

* Fix block number to file number calculation

Signed-off-by: Matilda Clerke <[email protected]>

* Correctly use accumulator hash in era1 filename

Signed-off-by: Matilda Clerke <[email protected]>

* Update manual test to use nimbus.team source for expected era1 file

Signed-off-by: Matilda Clerke <[email protected]>

* Add javadoc to new Era1* files

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest

Signed-off-by: Matilda Clerke <[email protected]>

* Add MerkleizerTest

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor to produce Era1FileWriter

Signed-off-by: Matilda Clerke <[email protected]>

* Add unit test for Era1FileWriter, fix discovered bug in Era1FileWriter

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor to produce Era1Accumulator and add unit test

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor to produce Era1BlockIndexConverter and add unit test

Signed-off-by: Matilda Clerke <[email protected]>

* Unit test Era1BlockExporter

Signed-off-by: Matilda Clerke <[email protected]>

* Fix javadoc issues

Signed-off-by: Matilda Clerke <[email protected]>

* Rename difficultysForFile to difficultiesForFile

Signed-off-by: Matilda Clerke <[email protected]>

* Move network selection outside of loop

Signed-off-by: Matilda Clerke <[email protected]>

* Make blocks export option non-hidden, add changelog entry

Signed-off-by: Matilda Clerke <[email protected]>

* Use network option in era1 block exporter

Signed-off-by: Matilda Clerke <[email protected]>

* Change Era1BlockExporter.export arguments to start/end block, and handle file number conversion internally

Signed-off-by: Matilda Clerke <[email protected]>

* Add additional Merkleizer tests and guard against empty leaves

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest

Signed-off-by: Matilda Clerke <[email protected]>

* Move new rlp encoder classes into encoding package, add encodeWrapped for BlockBodyEncoder, add TransactionReceiptEncodingConfiguration parameter to TransactionReceiptEncoder.encode

Signed-off-by: Matilda Clerke <[email protected]>

---------

Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* remove parentBeaconBlockRoot from getPayload result to match the specs

Signed-off-by: Ameziane H. <[email protected]>
Signed-off-by: [email protected] <[email protected]>
…9318)

* add burn-in tasks

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
…ledger#9183)

Co-authored-by: Sally MacFarlane <[email protected]>

Allows for enabling and disabling stack, storage, returnData, etc.. for these 2 specific RPC endpoints: debug_traceStandardBlockToFile and debug_traceStandardBadBlockToFile. It does not change any previous defaults for memory which is shown by default.

Example of usage:

curl --location --globoff 'http://localhost:8545' --data '{
    "jsonrpc": "2.0",
    "method": "debug_standardTraceBlockToFile",
    "params": [
        "0x2476b23a03dd87f272724a12213dc4a1ca8f13a1aa9d128a690e1b7d7d312e5e",
        {
            "txHash": "0xdfd5028da0f2f306ae71dc558c26bb1935b13ec3a0e909223eaa77bf761189a8",
            "disableStack": true,
            "disableMemory": false,
            "disableStorage": false
        }
    ],
    "id": 1
}'

curl --location --globoff 'http://localhost:8545/' --data '{
    "jsonrpc": "2.0",
    "method": "debug_standardTraceBadBlockToFile",
    "params": [
        "0x2476b23a03dd87f272724a12213dc4a1ca8f13a1aa9d128a690e1b7d7d312e5e",
        {
            "txHash": "0xdfd5028da0f2f306ae71dc558c26bb1935b13ec3a0e909223eaa77bf761189a8",
            "disableStack": true,
            "disableMemory": false,
            "disableStorage": false
        }
    ],
    "id": 1
}'

Signed-off-by: [email protected] <[email protected]>
Also remove sigleton pattern from ReferenceTestProtocolSchedules.

Signed-off-by: [email protected] <[email protected]>
* update netty

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
…ng with peer task system usage (hyperledger#9178)

* Remove GetBlockFromPeerTask and RetryingGetBlockFromPeersTask, replacing with peer task system usage

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BackwardSyncContextTest

Signed-off-by: Matilda Clerke <[email protected]>

* Use preferred peer first for block retrieval in BlockPropagationManager

Signed-off-by: Matilda Clerke <[email protected]>

* Add new GetHeadersFromPeerTask constructor which doesn't take a block number and use it in SyncStepStep

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor PeerTaskExecutor usage in BlockPropagationManager for better readability

Signed-off-by: Matilda Clerke <[email protected]>

* Fix a != that should have been ==

Signed-off-by: Matilda Clerke <[email protected]>

* Re-add AbstractBlockPropagationManagerTest.shouldRequestBlockFromOtherPeersIfFirstPeerFails and modify to use mock PeerTaskExecutor

Signed-off-by: Matilda Clerke <[email protected]>

* Re-add BackwardSyncContextTest.whenBlockNotFoundInPeers_shouldRemoveBlockFromQueueAndProgressInNextSession

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest again, but differently

Signed-off-by: Matilda Clerke <[email protected]>

* Remove commented code

Signed-off-by: Matilda Clerke <[email protected]>

---------

Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: [email protected] <[email protected]>
fab-10 and others added 14 commits December 15, 2025 10:28
Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
…tion (hyperledger#9516)

* Fix: Ensure deterministic sub-protocol registration in ConsensusSchedule

Signed-off-by: saeeddawod <[email protected]>
Signed-off-by: [email protected] <[email protected]>
feat: Implement callTracer for debug_trace* methods

Major refactoring of the debug tracing infrastructure to support the callTracer
type with Geth-compatible output.

Key changes:
- Refactor DebugCallTracerResult to support hierarchical call stack
- Introduce TracerType enum and TracerOptions simplification
- Rename StructLogTracerConfig to OpCodeTracerConfig for clarity
- Rename tracer result classes for consistency (OpCodeLoggerTracerResult, etc.)
- Implement CallTracerResultConverter for converting trace frames to call traces
- Add TraceFrame Builder pattern with precompile input/output fields
- Handle precompile calls with correct gas calculation and input/output
- Support SELFDESTRUCT, CREATE/CREATE2 operations in call traces
- Handle exceptional halts and soft failures with proper error descriptions
- Add feature flag for extra debug tracers
- Add comprehensive unit and integration tests for callTracer

---------

Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: [email protected] <[email protected]>
)

* simple fix

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* Revert "accept client or server timeout for flaky timeout test (hyperledger#9552)"

This reverts commit 4e088d6.

    Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>

* Revert "feat: Add RPC timeout interruption with CompletableFuture-based implementation (hyperledger#9117)"

This reverts commit 01bfb85.

    Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@pinges pinges marked this pull request as ready for review December 18, 2025 06:50
Copilot AI review requested due to automatic review settings December 18, 2025 06:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@pinges pinges requested a review from Copilot December 19, 2025 07:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Open PRs

Development

Successfully merging this pull request may close these issues.