Skip to content

Conversation

@garyschulte
Copy link
Contributor

PR description
PR to include an preimage storage. This PR is a reprise of 7800. Do not merge

Highlights include:

cli feature param
import/export preimage storage subcommands
forest persisted or in-memory preimages store
bonsai persisted, in-memory limited, in-memory unbounded preimage store
refactoring, removing of reference test specific behavior
incorporation into worldstatekeyvaluestorage classes
✅ reference tests passing

Fixed Issue(s)
fixes #7796

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@garyschulte garyschulte added the DO NOT MERGE label to not merge PR yet - PR has some pending checks before merging label Dec 9, 2025
garyschulte and others added 8 commits December 8, 2025 20:29
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…taStorageOptions.java

Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
@garyschulte garyschulte force-pushed the feature/preimage-store branch from 287082d to 4b1cfa6 Compare December 9, 2025 04:29
Signed-off-by: garyschulte <[email protected]>
@garyschulte
Copy link
Contributor Author

rebasing very likely broke in-memory preimage storage modes.

todo: fix in-memory limited, in-memory unbounded preimage store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE label to not merge PR yet - PR has some pending checks before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Implement hash preimage storage persistence

1 participant