-
Notifications
You must be signed in to change notification settings - Fork 994
feat: Implemented transaction selection time of high score transactions #9554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Implemented transaction selection time of high score transactions #9554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
@Shivang14d04 thanks for the PR - can you rebase off latest main please, then we can get someone to review. Thanks! |
Signed-off-by: Shivang <[email protected]>
Signed-off-by: Shivang <[email protected]>
d3a71a6 to
c5c2f0f
Compare
|
Hi @macfarla, I’ve rebased the PR on the latest main. The branch is now ready for review. |
fab-10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahamlat is this what you want? from the description I could assume that you only want the time spent processing tx with the highest score
| // adding a grace time so we are sure it take strictly more than the block | ||
| // selection max time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not reformat these comments if not needed
I think this implementation doesn't address the issue I created. The idea of the issue is to have the "real selection time" in case of selection timeout. Let's say a block of 10 transactions was built where each transaction took 1ms to be selected, and the 11th transaction was too slow to be selected and triggered timeout :
In this, I would like to have the time it took to select tx 1 to tx 10, instead of just having 1.8 second in case of a 2 seconds block time. @Shivang14d04 Your implementation should be reviewed to address the case I shared. |
PR description
This PR adds the time spent selecting high-scored transactions during block creation.
This change adds a new timing metric,
txsSelectionHighScore, which is measured during transaction pool selection and logged alongside existing block creation timing metrics.Fixed Issue(s)
fixes #9179
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests