Skip to content

Conversation

@lu-pinto
Copy link
Member

@lu-pinto lu-pinto commented Dec 10, 2025

PR description

The goal of this PR is to refactor types like Hash, Address, LogTopic, LogsBloomFilter, ... that extend DelegatingBytes in order to mitigate megamorphic calls in the EVM. This enables easier integration with a new version of tuweni that will have a more concise class hierarchy.

NOTE: This change is supposed to be side effect free.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@lu-pinto lu-pinto force-pushed the remove-delegatingbytes-dependency branch from b67f4be to b2f77c7 Compare December 10, 2025 00:44
@lu-pinto
Copy link
Member Author

I can't see any performance issues with NewPayload on mainnet:
image

image

@lu-pinto lu-pinto force-pushed the remove-delegatingbytes-dependency branch from 7b86dc6 to 92babf4 Compare December 15, 2025 23:28
@lu-pinto lu-pinto force-pushed the remove-delegatingbytes-dependency branch from 92babf4 to 91b9573 Compare December 18, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant