-
Notifications
You must be signed in to change notification settings - Fork 994
[Plugin System] Create WorldStateArchiveProvider interface #9448 #9561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AliZDev-v0
wants to merge
26
commits into
hyperledger:main
Choose a base branch
from
AliZDev-v0:ali/create-archive-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Plugin System] Create WorldStateArchiveProvider interface #9448 #9561
AliZDev-v0
wants to merge
26
commits into
hyperledger:main
from
AliZDev-v0:ali/create-archive-provider
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f613f69 to
9c2ffe7
Compare
3067b8a to
456070d
Compare
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
Signed-off-by: Ali Zhagparov <[email protected]>
456070d to
20672f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Hello, I would like to make contributions into besu, I was not able to find easier task with less changes
Feel free to close these PR, if it's irrelevant. I also can break down it to smaller PR's to make review easier
In order to create
WorldStateArchiveProviderinplugin-apinext interfaces were need to be moved intoplugin-apimoduleFor next classes interfaces were created but functionality stayed the same:
Javadoc was required for above classes, it was generated with AI, for me seems good
Since interface were moved from
eth/coretoplugin-apiI was need to replaceorg.hyperledger.besu.ethereum.core. BlockHeadertoorg.hyperledger.besu.plugin.data.BlockHeaderThere only one method not supported in interface is
toLogString(), I added a static method toethereum/core/Util.toLogString()to support itThe
WorldStateKeyValueStorageis used instead ofWorldStateStorageCoordinatorbecauseForestWorldStateArchivedo not need worldStateStorageCoordinator it needsWorldStateKeyValueStorageFixed Issue(s)
[Plugin System] Create WorldStateArchiveProvider interface #9448
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required. // Not sure about theseLocally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest// not working on my local./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests