Skip to content

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented Dec 15, 2025

PR description

Built on top of #9563, please review it first.

Calls to plugins_reloadPluginConfig RPC method always return success because they just trigger the reload of the plugin configuration, without waiting for the result, but this results in a bad UX for the caller, since he has no clue about the success or not of the operation, unless it looks in the logs.

Since reloading plugin configurations should be a fast operation, no more that few seconds in the worst cases, it makes sense to wait for the reloads to complete and return the result of the operations to the caller, so that if one or more reload operations fail, an error is returned, with a detailed error message, that specify which plugins have failed and the reason, and which plugin instead have reloaded their config successfully.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Copilot AI review requested due to automatic review settings December 15, 2025 16:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@fab-10 fab-10 added plugins doc-change-required Indicates an issue or PR that requires doc to be updated labels Dec 16, 2025
Signed-off-by: Fabio Di Fabio <[email protected]>

# Conflicts:
#	acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/plugins/PluginConfigurationReloadTest.java
@fab-10 fab-10 force-pushed the sync-plugin-reload-configuration-response branch from 567dfcb to 062c7bf Compare December 19, 2025 11:02
@fab-10 fab-10 force-pushed the sync-plugin-reload-configuration-response branch from 062c7bf to 247f40d Compare December 19, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-change-required Indicates an issue or PR that requires doc to be updated plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant