Change plugins_reloadPluginConfig RPC method to return the result of the reload
#9573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Built on top of #9563, please review it first.Calls to
plugins_reloadPluginConfigRPC method always return success because they just trigger the reload of the plugin configuration, without waiting for the result, but this results in a bad UX for the caller, since he has no clue about the success or not of the operation, unless it looks in the logs.Since reloading plugin configurations should be a fast operation, no more that few seconds in the worst cases, it makes sense to wait for the reloads to complete and return the result of the operations to the caller, so that if one or more reload operations fail, an error is returned, with a detailed error message, that specify which plugins have failed and the reason, and which plugin instead have reloaded their config successfully.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests