Add SyncTransactionReceipt, decoder, and update LogsBloomFilter to utilise raw Bytes #9574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilise raw Bytes Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
macfarla
reviewed
Dec 17, 2025
| // Flat receipts can be either legacy or eth/69 receipts. | ||
| // To determine the type, we need to examine the logs' position, as the bloom filter cannot be | ||
| // used. This is because compacted legacy receipts also lack a bloom filter. | ||
| // The first element can be either the transaction type (eth/69 or stateRootOrStatus (eth/68 |
Contributor
There was a problem hiding this comment.
Suggested change
| // The first element can be either the transaction type (eth/69 or stateRootOrStatus (eth/68 | |
| // The first element can be either the transaction type (eth/69) or stateRootOrStatus (eth/68) |
| } | ||
|
|
||
| @Test | ||
| public void testDecode() { |
Contributor
There was a problem hiding this comment.
Suggested change
| public void testDecode() { | |
| public void testDecodeLegacyReceipt() { |
Contributor
There was a problem hiding this comment.
is this testing legacy, or eth/69 ?
can you add test coverage for the other decode methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds SyncTransactionReceipt (similar to SyncBlockBody) to allow us to perform sync operations without fully parsing and duplicating the backing data. (PoC branch at #9416)