Skip to content

Check for empty accounts in code delegation processor #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniellehrner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check for empty accounts in code delegation processor #9585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...eum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/CodeDelegationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ private void processCodeDelegation(

MutableAccount authority;
boolean authorityDoesAlreadyExist = false;
if (maybeAuthorityAccount.isEmpty()) {

// we check for empty accounts as well in case we are on a chain that has still leftover empty
// accounts after EIP-7523
if (maybeAuthorityAccount.isEmpty() || maybeAuthorityAccount.get().isEmpty()) {
Copy link
Contributor

@matkt matkt Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that maybe this change can impact BAL tracking @mirgee ?

Copy link
Contributor

@mirgee mirgee Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add optional CI check to know for sure.

Copy link
Contributor Author

@daniellehrner daniellehrner Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that there can be empty accounts in the trie, not on mainnet, but on other chains, like rollups this might be an issue. This behaviour is consistent with what Geth and Nethermind are doing in case of empty accounts.

// only create an account if nonce is valid
if (codeDelegation.nonce() != 0) {
return;
Expand Down
Loading