Improve performance of peerselector peers #9586
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger#9411)" This reverts commit 8784c4e. Signed-off-by: Matilda Clerke <[email protected]>
…useless responses for some invalid responses Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…r task feature toggle in BackwardSyncStep Signed-off-by: Matilda Clerke <[email protected]>
Contributor
Author
|
Performance between test and control nodes looks to be the same now |
Contributor
|
Do you have times for BWS header download with and without your PR for comparison? |
Contributor
Author
|
Control node BWS header download was pretty consistant around 20 minutes. With these changes, they're both around the 20 minute mark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Improve performance during backward sync by using bestPeerComparator. Also implement recording useless responses from peers in PeerTaskExecutor to eventually disconnect bad peers.