Skip to content

In Snap Sync store Bodies and Receipts ASAP #9588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pinges wants to merge 253 commits into
base: main
Choose a base branch
from
Draft

In Snap Sync store Bodies and Receipts ASAP #9588

pinges wants to merge 253 commits into from

Conversation

@pinges
Copy link
Contributor

@pinges pinges commented Dec 19, 2025

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

mirgee and others added 30 commits December 15, 2025 10:25
@mirgee @pinges
Include generated BALs in debug_getBadBlocks response (hyperledger#…
e302cd0 
…9295)

Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@mirgee @fab-10 @pinges
EIP-7928 - Update engine API (hyperledger#9213)
ce1e70a 
* Update engine API

Signed-off-by: Miroslav Kovar <[email protected]>

* Add EngineGetPayloadV6Test

Signed-off-by: Miroslav Kovar <[email protected]>

* Revert changes to EngineForkchoiceUpdatedV3

Signed-off-by: Miroslav Kovar <[email protected]>

* Add EngineNewPayloadV5Test

Signed-off-by: Miroslav Kovar <[email protected]>

* Address code review comments

Signed-off-by: Miroslav Kovar <[email protected]>

* Fix failing test build

Signed-off-by: Miroslav Kovar <[email protected]>

* Fix failing test build

Signed-off-by: Miroslav Kovar <[email protected]>

---------

Signed-off-by: Miroslav Kovar <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@thomas-quadratic @moodmosaic @pinges
ADD: UInt256 implementation of evm's op MOD (hyperledger#9188)
49142ab 
* ADD: UInt256 implementation of evm's op MOD

Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Nikos Baxevanis <[email protected]>
Co-authored-by: Nikos Baxevanis <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@lu-pinto @pinges
Fix build for gitworktrees (hyperledger#9288)
19b1006 
Should fix support for running builds `./gradlew build` for besu when using a git-worktree setup. Previously there was a problem while parsing the besu version during the build since gradle was confused as to where to lookup for the commit hash.

Signed-off-by: [email protected] <[email protected]>
@lu-pinto @siladu @pinges
Add Option to enable/disable opcode optimizations (hyperledger#9299)
5b2d228 
* add evm options to evmtool too
* Statically initiatise SignatureAlgorithm default instance for reference tests

---------

Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
add blockTimestamp to logs within tx receipt (hyperledger#9294)
33ffa3a 
* add block timestamp to logs within transaction receipt and block receipts

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@mirgee @pinges
Activate BALs on amsterdam instead of futureEips (hyperledger#9296)
d34ef0c 
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@mirgee @pinges
EIP-7928 - Fix failing code clearing spec tests on main (hyperledger#…
91e90f6 
…9304)

Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@Gabriel-Trintinalia @pinges
test: upgrade to execution-spec-tests v5.3.0 (hyperledger#9301)
5352565 
* Bump spec tests

Signed-off-by: Gabriel-Trintinalia <[email protected]>

* changelog

Signed-off-by: Gabriel-Trintinalia <[email protected]>

---------

Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@usmansaleem @macfarla @pinges
chore: Update log4j to 2.25.2 (hyperledger#9312)
86f1b11 
Signed-off-by: Usman Saleem <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@bshastry @claude
@usmansaleem @siladu @pinges
Add test summary reporting to block-test command (hyperledger#9246)
6b61de1 
* Add test summary reporting to block-test command

The block-test command now tracks and displays a summary of test
execution results, including total tests, passed/failed counts, and
a list of failed tests with their failure reasons. This improves
usability when running large test suites by providing a clear
overview of test outcomes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Bhargava Shastry <[email protected]>

* Refactor block-test summary output for better maintainability

Address code review feedback by:
- Extract separator string into SEPARATOR constant to reduce duplication
- Reuse failureReason variable in output statements instead of duplicating
  formatting logic

This improves code maintainability by consolidating the failure message
formatting in a single location.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Bhargava Shastry <[email protected]>

* Address review feedback: simplify TestResults implementation

- Remove unused testName parameter from recordPass() method
- Remove totalTests field and calculate it dynamically in printSummary()
  from passed + failed counts
- Simplify SEPARATOR constant by removing embedded newline and use
  explicit out.println() for consistent formatting
- Add hasTests() helper method to check if any tests were executed

This reduces redundant state tracking and improves code clarity.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Bhargava Shastry <[email protected]>

---------

Signed-off-by: Bhargava Shastry <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Usman Saleem <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@mirgee @pinges
Only add CALL recipient to BAL if read (hyperledger#9314)
0043360 
Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@Matilda-Clerke @pinges
Implement era1 file export (hyperledger#9081)
f130d24 
* Implement era1 file export

Signed-off-by: Matilda Clerke <[email protected]>

* Clean up OutputStreamFactory to pass inspections

Signed-off-by: Matilda Clerke <[email protected]>

* fix javadoc

Signed-off-by: Matilda Clerke <[email protected]>

* fix javadoc

Signed-off-by: Matilda Clerke <[email protected]>

* fix more compile checks

Signed-off-by: Matilda Clerke <[email protected]>

* fix more compile checks

Signed-off-by: Matilda Clerke <[email protected]>

* fix more compile checks

Signed-off-by: Matilda Clerke <[email protected]>

* Output era1 files to supplied directory

Signed-off-by: Matilda Clerke <[email protected]>

* Implement accumulator and block index

Signed-off-by: Matilda Clerke <[email protected]>

* Fix compile errors

Signed-off-by: Matilda Clerke <[email protected]>

* Fix javadoc

Signed-off-by: Matilda Clerke <[email protected]>

* Couple of fixes, add logging

Signed-off-by: Matilda Clerke <[email protected]>

* Implement our own merkleizer, try many things

Signed-off-by: Matilda Clerke <[email protected]>

* Fix accumulator calculations

Signed-off-by: Matilda Clerke <[email protected]>

* Fix block number to file number calculation

Signed-off-by: Matilda Clerke <[email protected]>

* Correctly use accumulator hash in era1 filename

Signed-off-by: Matilda Clerke <[email protected]>

* Update manual test to use nimbus.team source for expected era1 file

Signed-off-by: Matilda Clerke <[email protected]>

* Add javadoc to new Era1* files

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest

Signed-off-by: Matilda Clerke <[email protected]>

* Add MerkleizerTest

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor to produce Era1FileWriter

Signed-off-by: Matilda Clerke <[email protected]>

* Add unit test for Era1FileWriter, fix discovered bug in Era1FileWriter

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor to produce Era1Accumulator and add unit test

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor to produce Era1BlockIndexConverter and add unit test

Signed-off-by: Matilda Clerke <[email protected]>

* Unit test Era1BlockExporter

Signed-off-by: Matilda Clerke <[email protected]>

* Fix javadoc issues

Signed-off-by: Matilda Clerke <[email protected]>

* Rename difficultysForFile to difficultiesForFile

Signed-off-by: Matilda Clerke <[email protected]>

* Move network selection outside of loop

Signed-off-by: Matilda Clerke <[email protected]>

* Make blocks export option non-hidden, add changelog entry

Signed-off-by: Matilda Clerke <[email protected]>

* Use network option in era1 block exporter

Signed-off-by: Matilda Clerke <[email protected]>

* Change Era1BlockExporter.export arguments to start/end block, and handle file number conversion internally

Signed-off-by: Matilda Clerke <[email protected]>

* Add additional Merkleizer tests and guard against empty leaves

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest

Signed-off-by: Matilda Clerke <[email protected]>

* Move new rlp encoder classes into encoding package, add encodeWrapped for BlockBodyEncoder, add TransactionReceiptEncodingConfiguration parameter to TransactionReceiptEncoder.encode

Signed-off-by: Matilda Clerke <[email protected]>

---------

Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@Gabriel-Trintinalia @pinges
Revert "Fix: colored output is lost with 25.7.0 (hyperledger#9250)" (h…
1cdb79d 
…yperledger#9320)

This reverts commit 42306f9.

Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
changelog (hyperledger#9322)
f31edf7 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@daniellehrner @pinges
Request block builder to finalize when we get a getPayload request (h…
72f1912 
…yperledger#9194)

Signed-off-by: [email protected] <[email protected]>
@ahamlat @pinges
remove parentBeaconBlockRoot from getPayload result (hyperledger#9316)
0a08952 
* remove parentBeaconBlockRoot from getPayload result to match the specs

Signed-off-by: Ameziane H. <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
tweaks to release checklist and container verify script (hyperledger#…
1dac634 
…9318)

* add burn-in tasks

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@lu-pinto @pinges
Enable/disable trace fields for RPCs that dump traces to files (hyper…
caf34d7 
…ledger#9183)

Co-authored-by: Sally MacFarlane <[email protected]>

Allows for enabling and disabling stack, storage, returnData, etc.. for these 2 specific RPC endpoints: debug_traceStandardBlockToFile and debug_traceStandardBadBlockToFile. It does not change any previous defaults for memory which is shown by default.

Example of usage:

curl --location --globoff 'http://localhost:8545' --data '{
    "jsonrpc": "2.0",
    "method": "debug_standardTraceBlockToFile",
    "params": [
        "0x2476b23a03dd87f272724a12213dc4a1ca8f13a1aa9d128a690e1b7d7d312e5e",
        {
            "txHash": "0xdfd5028da0f2f306ae71dc558c26bb1935b13ec3a0e909223eaa77bf761189a8",
            "disableStack": true,
            "disableMemory": false,
            "disableStorage": false
        }
    ],
    "id": 1
}'

curl --location --globoff 'http://localhost:8545/' --data '{
    "jsonrpc": "2.0",
    "method": "debug_standardTraceBadBlockToFile",
    "params": [
        "0x2476b23a03dd87f272724a12213dc4a1ca8f13a1aa9d128a690e1b7d7d312e5e",
        {
            "txHash": "0xdfd5028da0f2f306ae71dc558c26bb1935b13ec3a0e909223eaa77bf761189a8",
            "disableStack": true,
            "disableMemory": false,
            "disableStorage": false
        }
    ],
    "id": 1
}'

Signed-off-by: [email protected] <[email protected]>
@fab-10 @pinges
Cancelling a block creation, only stops the selection, to allow the b…
6213be6 
…lock to be completed (hyperledger#9332)

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@lu-pinto @pinges
Provide SECP256R1 default to precompile (hyperledger#9307)
71e6b06 
Also remove sigleton pattern from ReferenceTestProtocolSchedules.

Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
Update Netty to 4.2.7.Final (hyperledger#9330)
df52377 
* update netty

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@mirgee @pinges
Do not load recipient account when calculating CALL gas cost if trans…
1c1e6bc 
…fer value is zero (hyperledger#9315)

Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@Matilda-Clerke @pinges
Remove GetBlockFromPeerTask and RetryingGetBlockFromPeerTask, replaci…
46fdda9 
…ng with peer task system usage (hyperledger#9178)

* Remove GetBlockFromPeerTask and RetryingGetBlockFromPeersTask, replacing with peer task system usage

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BackwardSyncContextTest

Signed-off-by: Matilda Clerke <[email protected]>

* Use preferred peer first for block retrieval in BlockPropagationManager

Signed-off-by: Matilda Clerke <[email protected]>

* Add new GetHeadersFromPeerTask constructor which doesn't take a block number and use it in SyncStepStep

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor PeerTaskExecutor usage in BlockPropagationManager for better readability

Signed-off-by: Matilda Clerke <[email protected]>

* Fix a != that should have been ==

Signed-off-by: Matilda Clerke <[email protected]>

* Re-add AbstractBlockPropagationManagerTest.shouldRequestBlockFromOtherPeersIfFirstPeerFails and modify to use mock PeerTaskExecutor

Signed-off-by: Matilda Clerke <[email protected]>

* Re-add BackwardSyncContextTest.whenBlockNotFoundInPeers_shouldRemoveBlockFromQueueAndProgressInNextSession

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest again, but differently

Signed-off-by: Matilda Clerke <[email protected]>

* Remove commented code

Signed-off-by: Matilda Clerke <[email protected]>

---------

Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@Gabriel-Trintinalia @pinges
chore: eip-7935 bump mainnet gas limit to 60M (hyperledger#9339)
a2d1103 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@pinges
check whether we are syncing earlier in fcu
cce24e5 
Signed-off-by: [email protected] <[email protected]>
@fab-10 @pinges
Interrupt running selection task when block creation is cancelled (hy…
0aa284e 
…perledger#9337)

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@fab-10 @pinges
Introduce a more versatile txpool lifecycle logging (hyperledger#9333)
1a0a781 
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
CLI Tests - assert no errors before other assertions (hyperledger#9340)
946e94f 
* assert no errors before asserting method calls

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@jflo @macfarla @pinges
exclude icebox'd issues from being marked stale (hyperledger#9328)
6886fe1 
* exclude icebox'd issues from being marked stale

Signed-off-by: jflo <[email protected]>

* Update .github/workflows/stale-issues.yml

Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>

---------

Signed-off-by: jflo <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
fab-10 and others added 30 commits December 15, 2025 10:28
@fab-10 @macfarla @pinges
Improve output of plugin versions (hyperledger#9534)
c6ef0c5 
Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@saeeddawod @pinges
Fix: Register all BFT sub-protocols during IBFT2→QBFT consensus migra…
040c712 
…tion (hyperledger#9516)

* Fix: Ensure deterministic sub-protocol registration in ConsensusSchedule

Signed-off-by: saeeddawod <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@usmansaleem @pinges
feat: Implement callTracer for debug_trace* (hyperledger#9072)
a03e014 
feat: Implement callTracer for debug_trace* methods

Major refactoring of the debug tracing infrastructure to support the callTracer
type with Geth-compatible output.

Key changes:
- Refactor DebugCallTracerResult to support hierarchical call stack
- Introduce TracerType enum and TracerOptions simplification
- Rename StructLogTracerConfig to OpCodeTracerConfig for clarity
- Rename tracer result classes for consistency (OpCodeLoggerTracerResult, etc.)
- Implement CallTracerResultConverter for converting trace frames to call traces
- Add TraceFrame Builder pattern with precompile input/output fields
- Handle precompile calls with correct gas calculation and input/output
- Support SELFDESTRUCT, CREATE/CREATE2 operations in call traces
- Handle exceptional halts and soft failures with proper error descriptions
- Add feature flag for extra debug tracers
- Add comprehensive unit and integration tests for callTracer

---------

Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@matkt @pinges
rotate changelog - release 25.12.0-RC1 (hyperledger#9543)
9f49e13 
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
accept client or server timeout for flaky timeout test (hyperledger#9552
ba98395 
)

* simple fix

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@pinges
fix off by one
c43fc57 
Signed-off-by: [email protected] <[email protected]>
@pinges
optimize header retrieval
828e6a4 
Signed-off-by: [email protected] <[email protected]>
@macfarla @pinges
Revert "Rpc Timeout interruption (hyperledger#9117)" (hyperledger#9555)
01e2e76 
* Revert "accept client or server timeout for flaky timeout test (hyperledger#9552)"

This reverts commit 4e088d6.

    Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>

* Revert "feat: Add RPC timeout interruption with CompletableFuture-based implementation (hyperledger#9117)"

This reverts commit 01bfb85.

    Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@pinges
fix off by one and add unit tests
77cc18e 
Signed-off-by: [email protected] <[email protected]>
@pinges
more unit tests
d182c7a 
Signed-off-by: [email protected] <[email protected]>
@pinges
fix file generation
0cfe5ac 
Signed-off-by: [email protected] <[email protected]>
@Gabriel-Trintinalia @pinges
refactor: move target gas limit to network definition (hyperledger#9502)
06999b3 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@pinges
cleanup
0aac223 
Signed-off-by: [email protected] <[email protected]>
@pinges
some logging and comment improvements
9b7e7c0 
Signed-off-by: [email protected] <[email protected]>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
43c5eac 
Signed-off-by: [email protected] <[email protected]>
@pinges
fix some problems
187e7cd 
Signed-off-by: [email protected] <[email protected]>
@pinges
fix bft acceptance test
25130b9 
Signed-off-by: [email protected] <[email protected]>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
d4498cd
@pinges
add consensus as well
67bc075 
Signed-off-by: [email protected] <[email protected]>
@pinges
fix unit test
8a845f5 
Signed-off-by: [email protected] <[email protected]>
@pinges
remove some redundant tests and fix others
4127ed6 
Signed-off-by: [email protected] <[email protected]>
@pinges
remove and fix some more unit tests
f1612ba 
Signed-off-by: [email protected] <[email protected]>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
acc2f80
@pinges
more test clean-up
0defe82 
Signed-off-by: [email protected] <[email protected]>
@pinges
Merge branch 'main' of github.com:hyperledger/besu into HeadersBackward
8d66657
@pinges
experiment with storing earlier
4e3e092 
Signed-off-by: [email protected] <[email protected]>
@pinges
experiment with storing earlier
5a2e992 
Signed-off-by: [email protected] <[email protected]>
@pinges
use old peer task system for receipts
2d329b5 
Signed-off-by: [email protected] <[email protected]>
@pinges
remove unsused
05458fe 
Signed-off-by: [email protected] <[email protected]>
@pinges
just 3x
30700c2 
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.