Feature/integrate with cc tools #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Closed
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
39d2366 to
a064eb0
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Oct 11, 2024
Contributor
munapower
left a comment
munapower
left a comment
There was a problem hiding this comment.
I tried to follow but wasn't able to compile the changes for main.go
mbrandenburger
requested changes
Oct 13, 2024
Contributor
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks @osamamagdy this is pretty cool! Let's shape it a bit more!
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
92e4665 to
1ec09a9
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
87db6e1 to
ae668f1
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Nov 22, 2024
munapower
requested changes
Nov 22, 2024
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
approved these changes
Nov 26, 2024
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
samuelvenzi
reviewed
Nov 27, 2024
Contributor
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
I think this looks pretty good to me! My only remaining concern is about the readme instructions where sudo is used. As commented, I believe it not necessary for every developer ... and I think it is not good practise to let people run sudo commands when following this tutorial.
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
3053333 to
06e1453
Compare
Co-authored-by: Marcus Brandenburger <mbrandenburger@users.noreply.github.com> Signed-off-by: Osama Magdy <59124937+osamamagdy@users.noreply.github.com>
Co-authored-by: Marcus Brandenburger <mbrandenburger@users.noreply.github.com> Signed-off-by: Osama Magdy <59124937+osamamagdy@users.noreply.github.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
a99d1d0 to
2e80ab2
Compare
mbrandenburger
approved these changes
Nov 30, 2024
samuelvenzi
reviewed
Dec 2, 2024
| make | ||
| ``` | ||
|
|
||
| **Note**: For those who have arm-based computers, you should use the method recommended in the [main readme](https://github.com/hyperledger/fabric-private-chaincode?tab=readme-ov-file#fpc-playground-for-non-sgx-environments) for building both the cc-tools-demo chaincode as well as ercc. |
There was a problem hiding this comment.
I am with an M1 and building cc-tools-demo with the provided instructions (make) worked normally. Only needed the additional instructions for ercc.
Contributor
Author
There was a problem hiding this comment.
That's great but I think on @munapower side, she needed it for both I think? as per this comment #779 (comment)
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
added a commit
to osamamagdy/fabric-private-chaincode
that referenced
this pull request
Jan 17, 2025
CC-tools demo with FPC Create a new demo in `samples/chaincode/cc-tools-demo` to showcase the integration of FPC with CC-tools. The demo runs on top of the test-network sample simple-cli. Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a tutorial on how to integrate with cc-tools project, specially using the cc-tools-demo project
Which issue(s) this PR fixes:
Fixes the LFX mentorship project Hyperledger Fabric CC-Tools Support for Fabric Private Chaincode