Skip to content

Conversation

@mbrandenburger
Copy link
Contributor

This PR updates go and ego.

@mbrandenburger mbrandenburger requested a review from a team as a code owner April 1, 2025 12:40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we miss to update samples/application/ccapi/Dockerfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also missing samples/chaincode/cc-tools-demo/Dockerfile 5,5: ARG GO_VER=1.21

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also missing samples/chaincode/cc-tools-demo/Dockerfile 5,5: ARG GO_VER=1.21

Maria, that Dockerfile is pulled via the setup.sh script and is not part of the FPC repo. So we can ignore it here.

Copy link
Contributor

@chenchanglew chenchanglew Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for ego version update we miss to update the Ego version in readme ecc_go/README.md

Copy link
Contributor

@munapower munapower Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, there you can find wget https://github.com/edgelesssys/ego/releases/download/v1.5.3/ego_1.5.3_amd64_ubuntu-22.04.deb apt install ./ego_1.5.3_amd64_ubuntu-22.04.deb build-essential libssl-dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed

Copy link
Contributor

@munapower munapower Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, there you can find wget https://github.com/edgelesssys/ego/releases/download/v1.5.3/ego_1.5.3_amd64_ubuntu-22.04.deb apt install ./ego_1.5.3_amd64_ubuntu-22.04.deb build-essential libssl-dev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also missing samples/chaincode/cc-tools-demo/Dockerfile 5,5: ARG GO_VER=1.21

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
@mbrandenburger mbrandenburger merged commit d8e108e into hyperledger:main Apr 4, 2025
4 checks passed
@mbrandenburger mbrandenburger deleted the go-1.24 branch April 4, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants