Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Fix build break #702

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Oct 9, 2024

New version of grpc-js required 'fs/promises', which does not exist in the particular version of Node 12 included in the hyperledger/fabric-nodeenv:2.2 image. This was fixed in grpc-js v1.12.2.

This change includes npm-shrinkwrap.json files for the Node chaincode used by tests to avoid any unexpected future dependency version resolution changes.

@bestbeforetoday bestbeforetoday marked this pull request as ready for review October 9, 2024 21:45
@bestbeforetoday bestbeforetoday requested a review from a team October 9, 2024 21:45
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) October 9, 2024 21:45
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) October 9, 2024 22:35
New version of grpc-js required 'fs/promises', which does not exist in
the particular version of Node 12 included in the
hyperledger/fabric-nodeenv:2.2 image. This was fixed in grpc-js v1.12.2.

This change includes npm-shrinkwrap.json files for the Node chaincode
used by tests to avoid any unexpected future dependency version
resolution changes.

Signed-off-by: Mark S. Lewis <[email protected]>
@bestbeforetoday bestbeforetoday merged commit ffee7bc into hyperledger:main Oct 12, 2024
8 checks passed
@bestbeforetoday bestbeforetoday deleted the build-fix branch October 12, 2024 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant