[deliver] Fix flaky TestBroadcastDeliver#116
Merged
Merged
Conversation
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
force-pushed
the
flaky-deliver-test
branch
from
1ce36eb to
2679df0
Compare
cendhu
added a commit
to cendhu/fabric-x-committer
that referenced
this pull request
May 27, 2026
- Update fabric-x-common to commit 855f12b which fixes the FileLedger.Iterator underflow on empty ledger (PR hyperledger#116) - Remove the newest-start override in getCursor since FileLedger.Iterator now handles SeekPosition_Newest correctly on an empty ledger - Keep the stop guard for SeekPosition_Newest with height=0 since the stop number computation (height-1) remains in the committer Companion: hyperledger/fabric-x-common#116 Signed-off-by: Senthilnathan <cendhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
waitUntilGrpcServerIsDown()to ensure a server is down before testingRelated issues