Skip to content

[flaky-test] Increase error margin for a non-deterministic test #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cendhu merged 1 commit into from
Sep 16, 2025
Merged

[flaky-test] Increase error margin for a non-deterministic test #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions loadgen/workload/stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ func TestReadWriteWithValue(t *testing.T) {

func TestGenTxWithRateLimit(t *testing.T) {
t.Parallel()
p := DefaultProfile(8)
p := DefaultProfile(1)
limit := 1000
expectedSeconds := 5
producedTotal := expectedSeconds * limit
Expand All @@ -385,7 +385,7 @@ func TestGenTxWithRateLimit(t *testing.T) {
start := time.Now()
g.NextN(t.Context(), producedTotal)
duration := time.Since(start)
require.InDelta(t, float64(expectedSeconds), duration.Seconds(), 0.1)
require.InDelta(t, float64(expectedSeconds), duration.Seconds(), 0.1*float64(expectedSeconds))
}

// modGenTester simulates querying the version from the query service.
Expand Down