[docker-test] Add release-image–based containerized integration tests with TLS modes

[dean-amar]

Type of change

• Test update

Description

• Add release-image–based containerized integration tests with different TLS modes.
• Add support for multi-SAN server TLS credential creation.
• Align configuration names.
• Move common Docker utils to utils/test.

Additional details

The integration test runs each service in a separate Docker container and establishes connections between them with different TLS modes.
For now, we load TLS certificates into the mock-orderer container, even though it doesn’t support them yet (a future PR will add support).
We also need to align the config/template names, which will be addressed in a separate PR.

Related issues

• solves: [integration-test] add integration test for release images #123
• solves: [committer] containerized TLS test #124

[liran-funaro]

This looks good overall. Please address the comments,

[liran-funaro]

assembleBinds() is always called with the following pattern, where the intermediate variables (serverCredsPath, clientCredsPath) are only used for the input of assembleBinds().

	_, serverCredsPath := params.credsFactory.CreateServerCredentials(t, params.tlsMode, params.node)
	require.NotEmpty(t, serverCredsPath)
	_, clientCredsPath := params.credsFactory.CreateClientCredentials(t, params.tlsMode)
	require.NotEmpty(t, clientCredsPath)

    [...]

    assembleBinds(t,
		serverCredsPath,
		clientCredsPath,
        fmt.Sprintf("%s.yaml:/%s.yaml",
			filepath.Join(mustGetWD(t), localConfigPath, params.node), configPath,
		)
		fmt.Sprintf("%s:/%s", params.configBlockPath, filepath.Join(containerConfigPath, genBlockFile)),
	)

Thus, assembleBinds() should contain all this logic internally.

[dean-amar]

We can embed all of the logic into assembleBinds. However, when we try to bind a config file that doesn’t exist (as happens when we enable assembleBind for the db or orderer containers), Docker automatically creates directories with those names in the specified path (on the host).

To avoid that, we can move the following code into assembleBinds:

_, serverCredsPath := params.credsFactory.CreateServerCredentials(t, params.tlsMode, params.node)
require.NotEmpty(t, serverCredsPath)
_, clientCredsPath := params.credsFactory.CreateClientCredentials(t, params.tlsMode)
require.NotEmpty(t, clientCredsPath)

and then pass any differing binds as additional binds.

[liran-funaro]

minor: This can be embedded into assembleBinds().

[dean-amar]

Fixed.

[dean-amar]

Reverted and explained in the comment above.