[loadgen] Loadgen unit tests with TLS modes#145
Merged
Conversation
dean-amar
changed the title
dean-amar
changed the title
Comment on lines
+62
to
+64
| clientConf.Adapter.VerifierClient = startVerifiers(t, | ||
| test.InsecureTLSConfig, test.InsecureTLSConfig, | ||
| ) |
Contributor
There was a problem hiding this comment.
Why isn't it using the tested TLS mode?
Contributor
Author
There was a problem hiding this comment.
Actually, we can. Although this test is intended to verify the connection to the Loadgen service.
Fixed.
liran-funaro
approved these changes
Oct 16, 2025
liran-funaro
left a comment
liran-funaro
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a minor comment.
… each component Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
dean-amar
force-pushed
the
loadgen-tls-unit-test
branch
from
36bf380 to
e5e7043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Related issues