Skip to content

[proto] Remove redundant RPC GetLastCommittedBlockNumber() #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liran-funaro merged 1 commit into from
Nov 19, 2025
Merged

[proto] Remove redundant RPC GetLastCommittedBlockNumber() #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
315 changes: 124 additions & 191 deletions api/protoblocktx/block_tx.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions api/protoblocktx/block_tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ message BlockInfo {
uint64 number = 1;
}

message LastCommittedBlock {
optional BlockInfo block = 1;
}

message QueryStatus {
repeated string txIDs = 1;
}
Expand Down
91 changes: 41 additions & 50 deletions api/protocoordinatorservice/coordinator.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions api/protocoordinatorservice/coordinator.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ import "google/protobuf/empty.proto";
service Coordinator {
rpc BlockProcessing(stream Batch) returns (stream protoblocktx.TransactionsStatus);
rpc SetLastCommittedBlockNumber (protoblocktx.BlockInfo) returns (google.protobuf.Empty) {};
rpc GetLastCommittedBlockNumber (google.protobuf.Empty) returns (protoblocktx.LastCommittedBlock) {};
rpc GetNextExpectedBlockNumber (google.protobuf.Empty) returns (protoblocktx.BlockInfo) {};
rpc GetNextBlockNumberToCommit (google.protobuf.Empty) returns (protoblocktx.BlockInfo) {};
rpc GetTransactionsStatus(protoblocktx.QueryStatus) returns (protoblocktx.TransactionsStatus);
rpc GetConfigTransaction(google.protobuf.Empty) returns (protoblocktx.ConfigTransaction) {};
rpc NumberOfWaitingTransactionsForStatus(google.protobuf.Empty) returns (WaitingTransactions);
Expand Down
63 changes: 13 additions & 50 deletions api/protocoordinatorservice/coordinator_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading