[coordinator] Introduce a unified service manager#609
Open
liran-funaro wants to merge 1 commit into
Open
Conversation
liran-funaro
force-pushed
the
service-manager
branch
from
7f2e298 to
2bcd7f8
Compare
|
coverage: 91.367% (-0.04%) from 91.406% — liran-funaro:service-manager into hyperledger:main |
Contributor
|
I am not comfortable with adding more abstractions to the code. Bug can be fixed in the current flow. We need to discuss on the abstraction such as servicemanager. |
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
force-pushed
the
service-manager
branch
from
2bcd7f8 to
482bd67
Compare
Contributor
Author
I added an issue to address this. Please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
To address the VC manager's failed handling of the stream end, this commit introduces a unified service manager.
This way, we avoid cases where one instance is fixed while the other remains buggy.
This commit also splits the VC manager from the VC manager API, which can communicate with any VC.
Related issues