[BREAKING] Add CLI command for database initialization#617
Open
dean-amar wants to merge 4 commits into
Open
Conversation
…ust be executed after the database is healthy and running, and before performing any operation against the database. Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
|
coverage: 91.8% (+0.3%) from 91.501% — dean-amar:admin-db-init into hyperledger:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
init-dbCLI command that allows administrators to initialize the database (create system tables, metadata tables, and system namespaces) as a standalone operation before starting services. The change includes a BREAKING API modification: the SetupSystemTablesAndNamespaces RPC method has been removed from theVCservice as database initialization is now performed via CLI instead of gRPC.Additional details (Optional)
Although the
cmd/config/samples/dbinit.yamlis a duplication of the database sub-config section of thevcandqueryservices, I think that we should separate this configuration file for further usage. We can load the database configuration from thevcorqueryconfigs, but we want to keep the init-db command independent and focused solely on database initialization without requiring service-specific configurations. This separation allows administrators to run database initialization in environments where service configs may not be available yet.Usage example:
committer init-db --config dbinit.yamlRelated issues