[coordinator] restrict batch size#87
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements batch size restriction to handle gRPC resource exhausted errors when communicating with verifier and vcservice. The changes add message size limits to gRPC connections and implement batch splitting logic to prevent oversized messages.
Key changes:
- Added gRPC message size limits to prevent resource exhausted errors
- Implemented batch splitting logic for both signature verifier and validator-committer services
- Enhanced test coverage with large message size scenarios
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/connection/server_util.go | Added max send/receive message size options to gRPC server |
| utils/connection/client_util.go | Added maxMsgSize constant with TODO for common configuration |
| service/coordinator/signature_verifier_manager.go | Implemented batch splitting logic for signature verifier service |
| service/coordinator/validator_committer_manager.go | Implemented batch splitting logic for validator-committer service |
| service/coordinator/signature_verifier_manager_test.go | Added test for large message handling and updated test helper functions |
| service/coordinator/validator_committer_manager_test.go | Added test for large message handling and updated test helper functions |
Comments suppressed due to low confidence (1)
service/coordinator/signature_verifier_manager_test.go:249
- This line appears to be unrelated to the test's purpose of validating all invalid transactions. It submits and validates a batch of 1 transaction before testing the invalid transactions scenario.
env.requireTxBatch(t, env.submitTxBatch(t, 1))
cendhu
force-pushed
the
restrict-grpc-batch-size
branch
2 times, most recently
from
f40974e to
7a05151
Compare
liran-funaro
approved these changes
Jul 29, 2025
liran-funaro
left a comment
liran-funaro
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just some minor comments.
cendhu
force-pushed
the
restrict-grpc-batch-size
branch
3 times, most recently
from
7683a34 to
52c25de
Compare
liran-funaro
approved these changes
Jul 31, 2025
liran-funaro
left a comment
liran-funaro
left a comment
Contributor
There was a problem hiding this comment.
Please see comments
| "retryableStatusCodes": []string{ | ||
| "UNAVAILABLE", | ||
| "DEADLINE_EXCEEDED", | ||
| "RESOURCE_EXHAUSTED", |
Contributor
There was a problem hiding this comment.
Can RESOURCE_EXHAUSTED be a temporary problem? If so, shouldn't we retry.
I understand that in the case this PR is solving, the error is permanent. But I'm not sure it is always the case for this error.
Contributor
Author
There was a problem hiding this comment.
I will revert this change for now. We can investigate more and make changes to this code later.
This commit restrict the batch size sent to verifier and vcservice when it receives resource exhausted status code on grpc. Signed-off-by: Senthil Nathan N <cendhu@gmail.com> Signed-off-by: senthil <cendhu@gmail.com>
Signed-off-by: senthil <cendhu@gmail.com>
cendhu
force-pushed
the
restrict-grpc-batch-size
branch
from
52c25de to
4808bfb
Compare
Signed-off-by: senthil <cendhu@gmail.com>
cendhu
force-pushed
the
restrict-grpc-batch-size
branch
from
4808bfb to
81241ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This commit restrict the batch size sent to verifier and vcservice when it receives resource exhausted status code on grpc.
Related issues