add monitoring routes #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
EnriqueL8
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Just need some clarification on a few things here:
- It looks like we don't use any of the work to build the server in FF Common in that PR referenced as we are using
httpserverpkg and notflappkg. We use the config spelling I believe. - For some reason we have bundled a Golang version upgrade as part of this PR?
- Loads of linting changes as well
Chengxuan
commented
Feb 20, 2025
Chengxuan
commented
Feb 20, 2025
Chengxuan
commented
Feb 20, 2025
Signed-off-by: Chengxuan Xing <[email protected]>
EnriqueL8
reviewed
Feb 20, 2025
Signed-off-by: Chengxuan Xing <[email protected]>
EnriqueL8
approved these changes
Feb 21, 2025
Signed-off-by: Chengxuan Xing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As elaborated in hyperledger/firefly-common#167, there is a need to expose more endpoints for operational checks.
This PR propose a new
monitoringsections in the configuration file for configurations of the monitoring server:metricsPathThe new monitoring server itself is a replacement for the existing metrics server.
As a result the existing
metricssection is marked as deprecated.