Pull_request template #1604
Merged
Pull_request template #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
EnriqueL8
reviewed
Dec 3, 2024
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Thanks - one small comment
| - [ ] I have commented my code, particularly in hard-to-understand areas. | ||
| - [ ] My changes generates no new warnings. | ||
| - [ ] My Pull Request title is in format <code>< issue name ></code> eg <code>Added links in the documentation</code>. | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works. |
Contributor
There was a problem hiding this comment.
Can you add a checkbox about code coverage here please
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1592
Based on https://github.com/hyperledger-labs/documentation-template/blob/main/.github/pull_request_template.md