Skip to content

Conversation

@EnriqueL8
Copy link
Contributor

Proposed changes

Fix various CVEs detected from scorecard

image

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8 EnriqueL8 requested a review from a team as a code owner February 3, 2025 17:38
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8 EnriqueL8 mentioned this pull request Feb 4, 2025
2 tasks
@EnriqueL8
Copy link
Contributor Author

Going to figure out why I am getting

=== RUN   TestResolveSignerFailedFabricCARequest
    fabric_test.go:1461: 
        	Error Trace:	/home/runner/work/firefly/firefly/internal/blockchain/fabric/fabric_test.go:1461
        	Error:      	Error message not equal:
        	            	expected: "FF10284: Error from fabconnect: %!!(MISSING)s(<nil>)"
        	            	actual  : "FF10284: Error from fabconnect: %!s(<nil>)"
        	Test:       	TestResolveSignerFailedFabricCARequest
--- FAIL: TestResolveSignerFailedFabricCARequest (0.00s)

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (0f3a71b) to head (82ae4ae).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1630   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         337      337           
  Lines       29504    29504           
=======================================
  Hits        29492    29492           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
shorsher
shorsher previously approved these changes Feb 12, 2025
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8 EnriqueL8 merged commit ca61328 into main Feb 18, 2025
17 checks passed
@EnriqueL8 EnriqueL8 deleted the fix_cve branch February 18, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants