-
Notifications
You must be signed in to change notification settings - Fork 240
refactor: use errors.New to replace fmt.Errorf with no parameters & fix typo #1653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: LesCyber <andi4cing@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1653 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 339 339
Lines 29780 29780
=======================================
Hits 29768 29768
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR @LesCyber , can you resolve the conflicts please 😃 |
Signed-off-by: LesCyber <167666635+LesCyber@users.noreply.github.com>
Done, thank you for review again |
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@LesCyber Needs an FMT fix before it can go in |
Signed-off-by: LesCyber <andi4cing@gmail.com>
It's done |
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Replaced fmt.Errorf with errors.New in cases where formatting is not required. This reduces unnecessary function calls, leading to slightly improved performance and cleaner code.