Skip to content

Conversation

@LesCyber
Copy link
Contributor

@LesCyber LesCyber commented Mar 3, 2025

  1. use errors.New to replace fmt.Errorf with no parameters
  2. fix typo
  3. unify the error handling methods that are different from the project style

Replaced fmt.Errorf with errors.New in cases where formatting is not required. This reduces unnecessary function calls, leading to slightly improved performance and cleaner code.

Signed-off-by: LesCyber <andi4cing@gmail.com>
@LesCyber LesCyber requested a review from a team as a code owner March 3, 2025 12:09
Signed-off-by: LesCyber <andi4cing@gmail.com>
@LesCyber LesCyber changed the title refactor: use errors.New to replace fmt.Errorf with no parameters refactor: use errors.New to replace fmt.Errorf with no parameters & fix typo Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (1b9a69e) to head (96c538e).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         339      339           
  Lines       29780    29780           
=======================================
  Hits        29768    29768           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EnriqueL8
Copy link
Contributor

EnriqueL8 commented Mar 10, 2025

Thanks for the PR @LesCyber , can you resolve the conflicts please 😃

Signed-off-by: LesCyber <167666635+LesCyber@users.noreply.github.com>
@LesCyber
Copy link
Contributor Author

Thanks for the PR @LesCyber , can you resolve the conflicts please 😃

Done, thank you for review again

EnriqueL8
EnriqueL8 previously approved these changes Mar 10, 2025
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnriqueL8
Copy link
Contributor

@LesCyber Needs an FMT fix before it can go in

Signed-off-by: LesCyber <andi4cing@gmail.com>
@LesCyber
Copy link
Contributor Author

@LesCyber Needs an FMT fix before it can go in

It's done

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@EnriqueL8 EnriqueL8 merged commit 1856c5c into hyperledger:main Mar 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants