Update contract listener documentation to be clearer #1665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 339 339
Lines 29782 29782
=======================================
Hits 29770 29770
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthew1001
approved these changes
Mar 18, 2025
Contributor
matthew1001
left a comment
matthew1001
left a comment
There was a problem hiding this comment.
The update looks great, thanks. Just a couple of suggestions on heading casing
doc-site/docs/reference/types/_includes/contractlistener_description.md
Outdated
Show resolved
Hide resolved
doc-site/docs/reference/types/_includes/contractlistener_description.md
Outdated
Show resolved
Hide resolved
doc-site/docs/reference/types/_includes/contractlistener_description.md
Outdated
Show resolved
Hide resolved
…iption.md Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
…iption.md Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
…iption.md Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
peterbroadhurst
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1656
Types of changes
Please make sure to follow these points