Skip to content

fix: subscriptions historical filtering #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnriqueL8 merged 3 commits into from
Jul 8, 2025
Merged

fix: subscriptions historical filtering #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8a314f
fix: subscriptions historical filtering
EnriqueL8 Apr 1, 2025
df1ae59
Merge branch 'main' into fix_subs_events_apis
EnriqueL8 Apr 30, 2025
04fb066
Merge branch 'main' into fix_subs_events_apis
EnriqueL8 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/events/event_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,6 @@ func (em *eventManager) QueueBatchRewind(batchID *fftypes.UUID) {
}

func (em *eventManager) FilterHistoricalEventsOnSubscription(ctx context.Context, events []*core.EnrichedEvent, sub *core.Subscription) ([]*core.EnrichedEvent, error) {
// Transport must be provided for validation, but we're not using it for event delivery so fake the transport
sub.Transport = "websockets"
subscriptionDef, err := em.subManager.parseSubscriptionDef(ctx, sub)
if err != nil {
return nil, err
Expand Down
1 change: 1 addition & 0 deletions internal/events/event_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,7 @@ func TestEventFilterOnSubscriptionMatchesEventType(t *testing.T) {
}

subscription := &core.Subscription{
Transport: "websockets",
Filter: core.SubscriptionFilter{
Events: core.EventTypeIdentityConfirmed.String(),
},
Expand Down