fix: check for valid schema before querying by constrained field #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add/update tests; use errors.New instead of fmt.Errorf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #74. If querying (modusDB.Get) for a struct's constrained field before the schema contained that type, the worker would panic (the bug contains that trace). This change ensures the schema contains the type before launching the query. Note that querying by uid does not suffer from this issue as the discovery of the tablets (groups) are not involved in the query.
Also added tests (as well as expanding existing unit tests) and changed the api file to use errors.New instead of the fmt package as no formatting was being applied.
Checklist
CHANGELOG.mdfile describing and linking tothis PR