Skip to content

MultipleImageFetcher crashfix #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MultipleImageFetcher crashfix #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Sources/Shared/Fetcher/MultipleImageFetcher.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ public class MultipleImageFetcher {

private var fetchers: [ImageFetcher] = []
private let fetcherMaker: () -> ImageFetcher
private let syncQueue: DispatchQueue = .init(label: "multiple.fetcher.queue")

public init(fetcherMaker: @escaping () -> ImageFetcher) {
self.fetcherMaker = fetcherMaker
Expand All @@ -26,11 +27,15 @@ public class MultipleImageFetcher {
var results: [Result] = []

zip(fetchers, urls).forEach { fetcher, url in
fetcher.fetch(url: url, completion: { result in
fetcher.fetch(url: url, completion: { [weak self] result in
guard let self = self else { return }

each?(result)

results.append(result)

self.syncQueue.sync {
results.append(result)
}

if results.count == urls.count {
completion?(results)
}
Expand Down