Skip to content

Conversation

@Anmol1696
Copy link
Collaborator

No description provided.

@Anmol1696 Anmol1696 requested a review from Copilot April 11, 2025 09:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

clients/js/packages/client/src/client.ts:900

  • Ensure that the 'forwardPortService' invocation uses the correct port mapping. Currently, the same 'ui.ports.rest' value is passed for both source and target ports; confirm that this is intended and adjust if a different target port is required.
this.config.ui?.forEach((ui) => {

@Anmol1696 Anmol1696 changed the title feature: first attempt to add ui to starship feature: add frontends to starship Apr 11, 2025
@Anmol1696 Anmol1696 merged commit e21e508 into main Apr 12, 2025
13 checks passed
@Anmol1696 Anmol1696 deleted the anmol/custom-ui-support branch April 12, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants