epic: starship v2 initialization #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2: types defination for the starship config
Anmol1696
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates version references and adjusts file paths for the new v2 monorepo layout.
- Bumps package versions to 3.14.1 in lerna.json and changelogs
- Redirects README badges and links from
clients/jsto the newpackagesdirectory - Updates GitHub Actions workflows to run against the
packagesfolder
Reviewed Changes
Copilot reviewed 98 out of 98 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/packages/cli/CHANGELOG.md | Added v3.14.1 and v3.14.0 entries; version jump noted |
| packages/lerna.json | Bumped monorepo version to 3.14.1 and allowed v2 branch |
| packages/README.md | Updated badge links and package directory URLs |
| packages/CHANGELOG.md | Added multiple new version entries up to v3.14.1 |
| .github/workflows/run-client-tests.yml | Changed paths and working-directory to packages |
| .github/workflows/pr-tests.yaml | Updated install steps to packages directory |
| .github/workflows/lint-client.yml | Updated paths and working-directory to packages |
Comments suppressed due to low confidence (4)
packages/README.md:11
- The license link points to
packages/LICENSE, but the repository's LICENSE file lives at the root. Please update this URL to the correct path (e.g.,/LICENSE).
</a><a href="https://github.com/hyperweb-io/starship/blob/main/packages/LICENSE"><img height="20" src="https://img.shields.io/badge/license-MIT-blue.svg"></a>
packages/README.md:28
- The link target includes a duplicated
packagessegment (packages/packages/...). It should point directly to the package folder (e.g.,packages/starshipjs), so the link works correctly.
[`StarshipJS`](https://github.com/hyperweb-io/starship/tree/main/packages/packages/starshipjs): A JavaScript library providing...
.github/workflows/run-client-tests.yml:25
- Setting
working-directorytopackagesruns commands in the monorepo root packages folder, not in a specific package. Specify the actual CLI package path (e.g.,packages/cli) to ensure the intended tests are executed.
working-directory: packages
packages/packages/cli/CHANGELOG.md:10
- The changelog for the CLI package jumps from v3.12.0 to v3.14.0, omitting v3.13.0. Please add an entry for v3.13.0 or note the intentional version skip to maintain clarity in the release history.
# [3.14.0](https://github.com/hyperweb-io/starship/compare/v3.13.0...v3.14.0) (2025-06-11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #695