Skip to content

Conversation

@Anmol1696
Copy link
Collaborator

No description provided.

@Anmol1696 Anmol1696 requested a review from Copilot June 23, 2025 09:29

This comment was marked as outdated.

@Anmol1696 Anmol1696 requested a review from Copilot June 24, 2025 14:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhance generator to support relayer configurations by merging defaults, building Kubernetes manifests, and integrating relayers into the builder pipeline.

  • Added a deepMerge utility and extended DefaultsManager to process relayer defaults
  • Introduced RelayerBuilder and factory logic to render relayer manifests
  • Updated BuilderManager to include RelayerBuilder and added tests for relayer scenarios

Reviewed Changes

Copilot reviewed 26 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
defaults.ts Added deepMerge, getRelayerDefaults, and processRelayer along with relayer handling in applyDefaults
builders/relayers/index.ts New factory and main builder for selecting and running relayer-specific builders
builders/relayers/base.ts Defined common relayer builder interfaces and helpers
builders/index.ts Added RelayerBuilder to the overall builder list
tests/test-utils/config.ts Added relayer configs for end-to-end testing
tests/defaults.test.ts Covered processRelayer, applyDefaults, and deepMerge behaviors
tests/builder.test.ts Added relayer manifest generation test
package.json Added test script
Comments suppressed due to low confidence (1)

packages/packages/generator/src/builders/relayers/index.ts:35

  • There is no test for the default case in RelayerBuilderFactory.createBuilder. Adding a test that an unsupported relayer.type throws a clear error will ensure coverage for invalid inputs.
      default:

@Anmol1696 Anmol1696 mentioned this pull request Jun 24, 2025
@Anmol1696 Anmol1696 merged commit c771338 into main Jun 24, 2025
3 checks passed
@Anmol1696 Anmol1696 deleted the anmol/generator-relayer branch June 24, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants