Skip to content

Conversation

@Anmol1696
Copy link
Collaborator

No description provided.

@Anmol1696 Anmol1696 requested a review from Copilot June 24, 2025 04:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors starship configuration types to improve organization and maintainability by introducing new interfaces and consolidating inline definitions.

  • Introduces new interfaces: ChainScripts, Env, Balance, and Upgrade
  • Replaces inline type definitions for scripts, env, ics, cometmock, and balances with these new interfaces
  • Updates related interfaces (Channel, Ics, Exposer, and Relayer) to align with the new type definitions
Comments suppressed due to low confidence (2)

packages/packages/types/src/config.ts:85

  • [nitpick] Consider adding JSDoc comments for the new interfaces (ChainScripts, Env, Balance, Upgrade) to enhance clarity and future maintainability.
export interface ChainScripts {

packages/packages/types/src/config.ts:109

  • If additional upgrade types are anticipated in the future, consider defining 'type' as a union of multiple values rather than a single literal to allow for extensibility.
  type?: 'build';

@Anmol1696 Anmol1696 merged commit b530491 into main Jun 24, 2025
3 checks passed
@Anmol1696 Anmol1696 deleted the anmol/types-cleanup branch June 24, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants